Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema for the Notes XML submission type #2293

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

sbelsk
Copy link
Collaborator

@sbelsk sbelsk commented Jun 29, 2024

This PR is part of a series meant to improve the submission validation in CDash. The changes introduce an initial schema for the "Notes" XML file types accepted by the CDash submission process. As in the other PRs, this schema has been tested against all such existing XML data files in the CDash repo.

@sbelsk sbelsk added this to the v3.5 milestone Jun 29, 2024
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure and types of this schema seem reasonable to me. This successfully passes against most of the Notes.xml files I have. The only errors I observed were memory-related, which can be addressed for all schema types in a future PR.

@zackgalbreath
Copy link
Contributor

Same issue as noted above (and here) -- this type of file can sometimes be too large to validate in memory. That being said, I'm okay with merging this & revisiting this issue in CDash 3.6 if @williamjallen and @sbelsk think that's wise.

@williamjallen williamjallen added this pull request to the merge queue Jul 3, 2024
Merged via the queue into Kitware:master with commit a624631 Jul 3, 2024
6 checks passed
@sbelsk sbelsk deleted the notes-xml-schema branch July 13, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants