Add schema for the Upload XML submission type
#2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
approved these changes
Jun 30, 2024
|
This tests well against production data, except for large XML files where it fails with: What do we think, merge as-is (perhaps with a caveat) or wait until we figure out a streaming solution for XML validation? |
|
We've seen this issue with other types of files too. It's an issue with the parser being unable to handle large files, not necessarily this particular schema file. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
This PR is part of a series meant to improve the submission validation in CDash. The changes introduce an initial schema for the "Upload" XML file type accepted by the CDash submission process. As in the other PRs, this schema has been tested against all such existing XML data files in the CDash repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series meant to improve the submission validation in CDash. The changes introduce an initial schema for the "Upload" XML file type accepted by the CDash submission process. As in the other PRs, this schema has been tested against all such existing XML data files in the CDash repo.