Double-bubble cryogenic tanks #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated docs Update bubble_geom.jl better comments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 76.41% 78.34% +1.92%
==========================================
Files 69 72 +3
Lines 13169 13460 +291
==========================================
+ Hits 10063 10545 +482
+ Misses 3106 2915 -191 ☔ View full report in Codecov by Sentry. |
|
Closing as superseded by PR #80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes inconsistencies in the geometry of the cryogenic tanks in the fuselage. Some models assumed that the geometry was a double bubble while others only applied to circular sections. Now, the tank cross-section can be a double bubble in general, following the fuselage section.
This PR also introduces a new function
double_bubble_geom()that can be used to calculate the geometric properties of a double bubble shape. This function could also be used infuseWfor the fuselage design.