UI changes to support value of extra vars as nested hash #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
extra_vars_format_changes
branch
2 times, most recently
from
aa040ba
to
8ca0381
Compare
- UI changes to support extra vars format in ManageIQ/manageiq#14697 - fixed broken spec test
h-kataria
force-pushed
the
extra_vars_format_changes
branch
from
8ca0381
to
183a85b
Compare
|
Checked commit h-kataria@183a85b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@h-kataria I tested with backend change. Everything works as designed 👍 |
|
pending core PR ManageIQ/manageiq#14697 |
|
@h-kataria Any idea why tests are failing? This needs to be merged along with the core PR so I do not want to do that until tests are passing. |
simaishi
pushed a commit
that referenced
this pull request
Apr 25, 2017
UI changes to support value of extra vars as nested hash (cherry picked from commit 8ac1a79)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI changes to support extra vars format in ManageIQ/manageiq#14697
@bzwei @gmcculloug please test/review.