extra_var to have metadata

[bzwei]

Before extra_vars are hash key-default_value pairs. Now the hash value is another hash used to be store metadata. The first metadata is default value

For example this is the format for :config_info before

      :config_info => {
        :provision  => {
          :extra_vars => {
            'key1' => 'val1',
            'key2' => 'val2'
          }
        }
      }

and this is the new format

      :config_info => {
        :provision  => {
          :extra_vars => {
            'key1' => {:default => 'val1'},
            'key2' => {:default => 'val2'}
          }
        }
      }

In the future we can add more metadata, for example

      :config_info => {
        :provision  => {
          :extra_vars => {
            'key1'      => {:type => 'Integer', :default => 1},
            'secrect' => {:password => true}
          }
        }
      }

[bzwei]

@miq-bot add_label enhancement, providers/ansible_tower, services, fine/yes
@miq-bot assign @gmcculloug

cc @h-kataria UI will need an update to use the new format to pass in the extra_vars to backend.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commit bzwei@e57b5ef with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. 🍰

[simaishi]

Fine backport details:

$ git log -1
commit 4f359963b172afad0144aaef8121236bbec07824
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Apr 25 09:45:06 2017 -0400

    Merge pull request #14697 from bzwei/extra_var_format
    
    extra_var to have metadata
    (cherry picked from commit b84a4ebee79cc9b250630c8aa11eab0ff200f648)

[bdunne]

Does this belong in a migration?

[bzwei]

No. Since beta release every new service is having the new format. We don't need provide a migration for pre-beta versions.