Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jquery-1.8 dependency after last use is gone #1430

Merged
merged 1 commit into from
May 26, 2017
Merged

Remove jquery-1.8 dependency after last use is gone #1430

merged 1 commit into from
May 26, 2017

Conversation

himdel
Copy link
Contributor

@himdel himdel commented May 24, 2017

It was used by vmrc consoles, removed in #979.

It was used by vmrc consoles, removed in #979
@miq-bot
Copy link
Member

miq-bot commented May 24, 2017

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/30c272c689505ddf0feb350c00a6f3192d3b5534 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this May 26, 2017
@mzazrivec mzazrivec added this to the Sprint 62 Ending Jun 5, 2017 milestone May 26, 2017
@mzazrivec mzazrivec merged commit a456340 into ManageIQ:master May 26, 2017
@himdel himdel deleted the jquery-1.8 branch June 5, 2017 12:57
simaishi pushed a commit that referenced this pull request Aug 17, 2017
Remove jquery-1.8 dependency after last use is gone
(cherry picked from commit a456340)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 58aa2162ff05d5ba605925a2f3e13edcea53bc50
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri May 26 09:50:43 2017 +0200

    Merge pull request #1430 from himdel/jquery-1.8
    
    Remove jquery-1.8 dependency after last use is gone
    (cherry picked from commit a456340922e2614252906b06a4e16aa1aa63495a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants