Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VMware MKS consoles and the old VMRC plugin support #979

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Remove VMware MKS consoles and the old VMRC plugin support #979

merged 1 commit into from
Apr 18, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Apr 10, 2017 •
edited
Loading

VMware no longer supports these features, so we're dropping them too.
Pivotal story: https://www.pivotaltracker.com/story/show/143409157
Thanks for @vecerek's help with the button tests 🎉

https://bugzilla.redhat.com/show_bug.cgi?id=1440811

@skateman skateman force-pushed the remove-old-vmware branch 2 times, most recently from cc7480c to 2060063 Compare April 10, 2017 13:11
@dclarizio dclarizio self-assigned this Apr 10, 2017
@skateman
Copy link
Member Author

@vecerek could you please help me with the failing tests? I'm totally lost in the shared examples you introduced 😞

@vecerek vecerek mentioned this pull request Apr 13, 2017
Closed
@skateman skateman changed the title [WIP] Remove VMware MKS consoles and the old VMRC plugin support Remove VMware MKS consoles and the old VMRC plugin support Apr 13, 2017
@miq-bot miq-bot removed the wip label Apr 13, 2017
@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2017

Checked commit skateman@0ac89d7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
9 files checked, 0 offenses detected
Everything looks good. 👍

@dclarizio dclarizio merged commit 34394f1 into ManageIQ:master Apr 18, 2017
@dclarizio dclarizio added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 18, 2017
@skateman skateman deleted the remove-old-vmware branch April 18, 2017 08:56
@simaishi
Copy link
Contributor

@skateman Getting a conflict in config/initializers/assets.rb when backporting this to Fine because of moving bower to ui-classic. Can everything else go in as is? If so, I'll backport this without assets.rb and you can create a separate PR in manageiq repo. Let me know.

@skateman
Copy link
Member Author

The things I'm deleting should not be in the assets.rb, creating a backport PR.

@simaishi
Copy link
Contributor

Fine PR: #1052

@simaishi
Copy link
Contributor

Backported to Fine via #1052

@himdel himdel mentioned this pull request May 24, 2017
Merged
This was referenced Jan 30, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
compute/infrastructure enhancement fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skateman @miq-bot @simaishi @dclarizio