Catalog Items - show all items, regardless of display=true #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in Service Catalogs, we correctly display only catalog items with `display=true` ("Display in Catalog")
in Catalog Items, we should show all of them, regardless of `display`, but previously, those with `display=false` would only be visible in the tree, not the right side
This makes the right side consistent with the tree.
Fixes #440
|
Before:
After:
(The same in Service Catalog - before and after are the same:)
|
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/8beaf07165f537325e47f1603ca46eb3daf5a451 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/catalog_controller.rb
|
|
@himdel Is there a BZ for this? Can you please create one if it doesn't exist? |
|
@simaishi I created https://bugzilla.redhat.com/show_bug.cgi?id=1430705, thanks :) |
|
Euwe backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to Services > Catalogs...
in Service Catalogs, we correctly display only catalog items with
display=true("Display in Catalog")in Catalog Items, we should show all of them, regardless of
display, but previously, those withdisplay=falsewould only be visible in the tree, not the right sideThis makes the right side consistent with the tree.
Fixes #440
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1430705
EUWE BZ: ...