Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services > Catalog Items - services in the tree don't match right side #440

Closed
himdel opened this issue Feb 21, 2017 · 2 comments
Closed
Assignees
Labels

Comments

@himdel
Copy link
Contributor

himdel commented Feb 21, 2017

Go to Services > Catalogs, Catalog Items accordion.

Expand a catalog item in the tree, and click on it.

I'd expect to see the same number of items on the left and on the right.

But:

bad1
bad2


This happens because the tree only filters by service_template_catalog_id = nil (code), whereas the right-side list also filters by display=true (that's the "Display in Catalog" option in service) (code).


@dclarizio, @h-kataria I'd love to fix this, but no idea which is correct. Should we be showing all the services here, or only those with "display in catalog" checked?

@dclarizio
Copy link

@himdel Catalog Items accordion is where the users manage catalog items, so all should show up here. The Service Catalogs accordion above is where the user orders services from and that is where we only show the ones with "display in catalog" checked.

So now you can fix it? :) Let me know if you have further questions.

@himdel
Copy link
Contributor Author

himdel commented Feb 22, 2017

Sure, that's all I need, thanks :)

@himdel himdel self-assigned this Feb 22, 2017
@himdel himdel added the bug label Feb 22, 2017
miha-plesko pushed a commit to miha-plesko/manageiq-ui-classic that referenced this issue Feb 27, 2017
in Service Catalogs, we correctly display only catalog items with `display=true` ("Display in Catalog")

in Catalog Items, we should show all of them, regardless of `display`, but previously, those with `display=false` would only be visible in the tree, not the right side

This makes the right side consistent with the tree.

Fixes ManageIQ#440
TomasKohoutek pushed a commit to TomasKohoutek/manageiq-ui-classic that referenced this issue Apr 7, 2017
in Service Catalogs, we correctly display only catalog items with `display=true` ("Display in Catalog")

in Catalog Items, we should show all of them, regardless of `display`, but previously, those with `display=false` would only be visible in the tree, not the right side

This makes the right side consistent with the tree.

Fixes ManageIQ#440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants