Remove the second (type) argument from TreeBuilder classes #5495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
drop-tree-type
branch
from
4af5fae
to
5150e85
Compare
skateman
force-pushed
the
drop-tree-type
branch
from
5150e85
to
093709d
Compare
|
Checked commit skateman@093709d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
skateman
changed the title
|
It's cool someone (you) is moving forward with the tree. |
martinpovolny
approved these changes
May 1, 2019
|
@miq-bot add_label changelog/yes |
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
May 8, 2019
Fixed 2 issues - Fixed `wrong number of arguments (given 4, expected 3)` error, removed 'type' argument that was being passed in to tree builder code, was introduced by ManageIQ#5495 - Fixed `comparison of Integer with String failed` error for `@assign[:new][:objects].sort!`, changed to push integer into objects array to fix comparison error on the sort when selecting nodes in the tree in 'Selections' box. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1707871 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1707886
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
May 8, 2019
Fixed 2 issues - Fixed `wrong number of arguments (given 4, expected 3)` error, removed 'type' argument that was being passed in to tree builder code, was introduced by ManageIQ#5495 - Fixed `comparison of Integer with String failed` error for `@assign[:new][:objects].sort!`, changed to push integer into objects array to fix comparison error on the sort when selecting nodes in the tree in 'Selections' box. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1707871 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1707886
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
typeandnamearguments are completely redundant and thetypeis not used anywhere so it is time to remove it.There are some tree initialization calls where the two arguments were swapped in order. This might cause some problems with
x_treeandx_active_treein the area as the name of the tree might not had the_treesuffix. Here are those:TreeBuilderSectionsTreeBuilderProtectTreeBuilderClustersTreeBuilderDatastoresTreeBuilderSmartproxyAffinityAlso I might have missed some cases where metaprogramming comes into the game so would be nice to go through some of the non-explorer trees a little.
@miq-bot add_label trees, cleanup, hammer/no
@miq-bot add_reviewer @ZitaNemeckova