Removed 'type' argument passed to the tree builder #5549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed 2 issues - Fixed `wrong number of arguments (given 4, expected 3)` error, removed 'type' argument that was being passed in to tree builder code, was introduced by ManageIQ#5495 - Fixed `comparison of Integer with String failed` error for `@assign[:new][:objects].sort!`, changed to push integer into objects array to fix comparison error on the sort when selecting nodes in the tree in 'Selections' box. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1707871 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1707886
|
Checked commit h-kataria@295ac4c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot assign @martinpovolny |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 2 issues
wrong number of arguments (given 4, expected 3)error, removed 'type' argument that was being passed in to tree builder code, was introduced by Remove the second (type) argument from TreeBuilder classes #5495comparison of Integer with String failederror for@assign[:new][:objects].sort!, changed to push integer into objects array to fix comparison error on the sort when selecting nodes in the tree in 'Selections' box.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1707871
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1707886