[BLOCKING] Clone optimade-python-tools and run docker-compose

[CasperWA]

Fixes #2

The initial work-around here is to git clone the optimade-python-repository into the temporary GH Actions server and - without installing anything - run the docker-compose.yml file found in the repository root of optimade-python-repository.

[shyamd]

So, the CI tests might be ill-conditioned here. The CI shouldn't be testing the optimade-server but the action. Since the action tests the optimade-server, we don't actually want to test the server in the CI. Rather we should just be testing to ensure the action is running the right command and properly failing/succeeding depending on the output of that command.

[CasperWA]

So, the CI tests might be ill-conditioned here. The CI shouldn't be testing the optimade-server but the action. Since the action tests the optimade-server, we don't actually want to test the server in the CI. Rather we should just be testing to ensure the action is running the right command and properly failing/succeeding depending on the output of that command.

Agreed. It's a bit wishy-washy where to draw the line at the moment though. But I have been introducing tests of entrypoint.sh via BATS in #4. Maybe that's more sensible in the end? Although I do think we should also have at least the two first tests from the CI or something similar to it to test that the optimade_validator will indeed be invoked correctly.

Edit: Right, so thinking more about this, I indeed wanted to run this action passing a URL as well, however, there wasn't anyone working I could come up with. But I guess we could try Heroku? The validator doesn't appreciate the (valid) provider.optimade.org still.
Also, I think, to properly test the action, we should test it should be able to handle a "local" server as well? But maybe we can compromise and state that this is tested from the optimade-python-tools library?

[shyamd]

Yup. I like the BATS testing. One viable option would be to make a dummy optimade-validator in the right place and ensure it gets called.

[CasperWA]

Yup. I like the BATS testing. One viable option would be to make a dummy optimade-validator in the right place and ensure it gets called.

Very nice idea. It just sets an environment variable, outputs something or other, which can then be tested with BATS 👍

[CasperWA]

So what do you say to get this merged as a temporary solution, opening the possibility of getting the other open PRs merged, create an issue to convert all CI to BATS testing (based on the work I started in #4) and then finally release v1 - the CI testing shouldn't hinder the release I think?

[ml-evs]

Missed the huge blocking sign when I reviewed the other PR first X)

[CasperWA]

Missed the huge blocking sign when I reviewed the other PR first X)

No worries - but what do you think about this comment?

Never mind, it seems all are on board 😄

[shyamd]

I agree, let's merge and then update.