Add parameter to choose optimade-python-tools version, branch, tag or commit #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasperWA
force-pushed
the
close_1_choose_version_of_optimade-python-tools
branch
3 times, most recently
from
c74cd54
to
acf2b61
Compare
CasperWA
force-pushed
the
close_1_choose_version_of_optimade-python-tools
branch
3 times, most recently
from
e9b15ee
to
e5e3f0f
Compare
ml-evs
previously approved these changes
Mar 12, 2020
There was a problem hiding this comment.
This looks nice @CasperWA, and addresses my concerns in the Materials-Consortia/optimade-python-tools#223. What's going on with the action tests though? I can't load the status at the moment
| # Retrieve and add GitHub Actions host runner IP to known hosts | ||
| DOCKER_HOST_IP=$(cat /docker_host_ip) | ||
| echo ${DOCKER_HOST_IP} gh_actions_host >> /etc/hosts | ||
|
|
||
| run_validator="optimade_validator" | ||
| run_validator="optimade_validator --verbosity 2" |
There was a problem hiding this comment.
Don't forget about that handy OPTIMADE_VERBOSITY env var!
There was a problem hiding this comment.
Hehehe, for sure - but I want to make it editable (see #7)
Can be either: - 'latest': Will install the latest PyPI released version - PyPI released version (e.g., 'v0.6.0' or '0.6.0') - optimade-python-tools branch, tag or commit (anything that is accepted by pip to install as reference) And will be tested for in that order as well. Update README with new parameter. Enforce --no-cache for installing optimade. Use tarball directly from GitHub.
The tests of the entrypoint.sh is based on BATS (https://github.com/bats-core/bats-core). It runs the tests in a docker container based on the bats/bats public docker image. Also, added the constraint that `vMAJOR.MINOR.PATCH` and `MAJOR.MINOR.PATCH` are the same, in terms of installing from PyPI. Add README section about running tests. New helpful sh script for running the tests. Use sh script to run tests in CI.
Note: The possibility to adjust verbosity should be added to the action
CasperWA
force-pushed
the
close_1_choose_version_of_optimade-python-tools
branch
from
876d18c
to
3fb365d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1
This adds the
validator versionparameter.It is required and defaults to
'latest'.It accepts anything
pipcan handle to install fromgit(see here) in terms of branches, tags, and commits.If a version is chosen, e.g.,
'0.6.0'it will install this version from PyPI.Finally, if
'latest'is chosen (the default), it will install the latest version from PyPI.