Skip to content

Commit

Permalink
Make interest income nullable (#81)
Browse files Browse the repository at this point in the history
* Make interest income nullable

* Remove count assert
  • Loading branch information
Matthiee authored Feb 6, 2023
1 parent f34af7c commit e4dce8c
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public class IncomeStatementResponse
public double CostAndExpenses { get; set; }

[JsonPropertyName("interestIncome")]
public double InterestIncome { get; set; }
public double? InterestIncome { get; set; }

[JsonPropertyName("interestExpense")]
public double InterestExpense { get; set; }
Expand Down
21 changes: 15 additions & 6 deletions Tests/CompanyValuation/CompanyValuationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,14 @@ public async Task GetEnterpriseValue(string symbol)
[InlineData("AGS.BR")]
[InlineData("PPL.TO")]
[InlineData("TSLA")]
[InlineData("AAP")]
[InlineData("MTG")]
public async Task GetIncomeStatement(string symbol)
{
var result = await api.GetIncomeStatementAsync(symbol, Period.Annual, 5);
var result = await api.GetIncomeStatementAsync(symbol, Period.Annual, 10000);

result.AssertNoErrors();
Assert.NotEmpty(result.Data);
Assert.Equal(5, result.Data.Count);
Assert.All(result.Data, data => Assert.Equal(symbol, data.Symbol));
}

Expand All @@ -158,6 +159,8 @@ public async Task GetIncomeStatement(string symbol)
[InlineData("AGS.BR")]
[InlineData("PPL.TO")]
[InlineData("TSLA")]
[InlineData("AAP")]
[InlineData("MTG")]
public async Task GetIncomeStatementPerQuarter(string symbol)
{
var result = await api.GetIncomeStatementAsync(symbol, Period.Quarter, limit: 10000);
Expand All @@ -173,13 +176,14 @@ public async Task GetIncomeStatementPerQuarter(string symbol)
[InlineData("AGS.BR")]
[InlineData("PPL.TO")]
[InlineData("TSLA")]
[InlineData("AAP")]
[InlineData("MTG")]
public async Task GetCashFlowStatement(string symbol)
{
var result = await api.GetCashFlowStatementAsync(symbol, Period.Annual, 5);
var result = await api.GetCashFlowStatementAsync(symbol, Period.Annual, 10000);

result.AssertNoErrors();
Assert.NotEmpty(result.Data);
Assert.Equal(5, result.Data.Count);
Assert.All(result.Data, data => Assert.Equal(symbol, data.Symbol));
}

Expand All @@ -189,6 +193,8 @@ public async Task GetCashFlowStatement(string symbol)
[InlineData("AGS.BR")]
[InlineData("PPL.TO")]
[InlineData("TSLA")]
[InlineData("AAP")]
[InlineData("MTG")]
public async Task GetCashFlowStatementPerQuarter(string symbol)
{
var result = await api.GetCashFlowStatementAsync(symbol, Period.Quarter, limit: 10000);
Expand All @@ -204,13 +210,14 @@ public async Task GetCashFlowStatementPerQuarter(string symbol)
[InlineData("AGS.BR")]
[InlineData("PPL.TO")]
[InlineData("TSLA")]
[InlineData("AAP")]
[InlineData("MTG")]
public async Task GetBalanceSheetStatement(string symbol)
{
var result = await api.GetBalanceSheetStatementAsync(symbol, Period.Annual, 5);
var result = await api.GetBalanceSheetStatementAsync(symbol, Period.Annual, 10000);

result.AssertNoErrors();
Assert.NotEmpty(result.Data);
Assert.Equal(5, result.Data.Count);
Assert.All(result.Data, data => Assert.Equal(symbol, data.Symbol));
}

Expand All @@ -220,6 +227,8 @@ public async Task GetBalanceSheetStatement(string symbol)
[InlineData("AGS.BR")]
[InlineData("PPL.TO")]
[InlineData("TSLA")]
[InlineData("AAP")]
[InlineData("MTG")]
public async Task GetBalanceSheetStatementPerQuarter(string symbol)
{
var result = await api.GetBalanceSheetStatementAsync(symbol, Period.Quarter, limit: 10000);
Expand Down

0 comments on commit e4dce8c

Please sign in to comment.