Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

what's this problem #4

Closed
LopSdir opened this issue Jul 15, 2022 · 3 comments · Fixed by #5
Closed

what's this problem #4

LopSdir opened this issue Jul 15, 2022 · 3 comments · Fixed by #5

Comments

@LopSdir
Copy link

LopSdir commented Jul 15, 2022

image

the config is the example.yml I use python3.9
MatthiasValvekens added a commit that referenced this issue Jul 15, 2022
@MatthiasValvekens
Reinstate asn1crypto registration of AA types
4121bbb 
Some extension registrations were inadvertently removed in the process
of upgrading asn1crypto and the removal of associated monkey patches
(see 87aaf7f). This issue went undetected in the tests because our test
suite imports pyhanko_certvalidator, which performs the same
registrations on import.

This commit restores the registration hook and makes sure it gets called
when the CLI is loaded.

Fixes #4.
@MatthiasValvekens
Copy link
Owner

Hi,

Thank you for reporting this issue.

That's indeed a bug, caused by an overeager deletion when I upgraded asn1crypto and got rid of a number of monkey patches in the process. In the process, I unfortunately also removed a number of X.509 extension registrations for stuff related to attribute certificates... What's more, that gaffe went undetected in the tests because the test suite imports pyhanko_certvalidator, which does perform these registrations correctly...

Anyway, I've made a commit to fix that, which I'll merge soon. After cleaning up a few other minor things, I'll do a patch release.

@MatthiasValvekens MatthiasValvekens mentioned this issue Jul 15, 2022
Merged
@MatthiasValvekens
Copy link
Owner

MatthiasValvekens commented Jul 15, 2022 •
edited
Loading

Should be fixed in 0.8.3 :)

@LopSdir
Copy link
Author

LopSdir commented Jul 18, 2022

thanks your help very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reinstate asn1crypto registration of AA types MatthiasValvekens/certomancer
2 participants
@MatthiasValvekens @LopSdir