Reinstate asn1crypto registration of AA types #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some extension registrations were inadvertently removed in the process of upgrading asn1crypto and the removal of associated monkey patches (see 87aaf7f). This issue went undetected in the tests because our test suite imports pyhanko_certvalidator, which performs the same registrations on import. This commit restores the registration hook and makes sure it gets called when the CLI is loaded. Fixes #4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extension registrations were inadvertently removed in the process of upgrading asn1crypto and the removal of associated monkey patches (see 87aaf7f). This issue went undetected in the tests because our test
suite imports
pyhanko_certvalidator, which performs the same registrations on import.This commit restores the registration hook and makes sure it gets called when the CLI is loaded.
Fixes #4.