Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use NFD helm charts from NFD repo #68

Closed
adrianchiris opened this issue Dec 10, 2020 · 1 comment · Fixed by #160
Closed

use NFD helm charts from NFD repo #68

adrianchiris opened this issue Dec 10, 2020 · 1 comment · Fixed by #160
Labels
enhancement New feature or request

Comments

@adrianchiris
Copy link
Collaborator

Apparently there are charts at:

https://github.com/k8s-at-home/charts/tree/master/charts/node-feature-discovery

perhaps we should use-them,

Should ping nfd folks ask if thats the official place they recommend to take charts from before swapping
@adrianchiris adrianchiris added the enhancement New feature or request label Dec 10, 2020
@adrianchiris
Copy link
Collaborator Author

adrianchiris commented Dec 28, 2020 •
edited
Loading

Update: ive pushed a PR to kubernetes-sigs/node-feature-discovery : kubernetes-sigs/node-feature-discovery#423

We should use that as reference once merged (or use it from repo if available)

@adrianchiris adrianchiris changed the title use NFD helm charts from k8s-at-home repo use NFD helm charts from NFD repo Dec 28, 2020
e0ne added a commit to e0ne/network-operator that referenced this issue Apr 2, 2021
@e0ne
Use upstream NFD chart
85bde97 
NFD charts are merged to NFD repo now so we don't need to duplicate
effort of maintaining charts.

Closes: Mellanox#68
Closes: Mellanox#111

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
@e0ne e0ne mentioned this issue Apr 2, 2021
Merged
e0ne added a commit to e0ne/network-operator that referenced this issue Apr 3, 2021
@e0ne
Use upstream NFD chart
c25d2a5 
NFD charts are merged to NFD repo now so we don't need to duplicate
effort of maintaining charts.

Closes: Mellanox#68
Closes: Mellanox#111

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Apr 6, 2021
@e0ne
Use upstream NFD chart
6ed18d2 
NFD charts are merged to NFD repo now so we don't need to duplicate
effort of maintaining charts.

Closes: Mellanox#68
Closes: Mellanox#111

depends-on: kubernetes-ci#104

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Apr 11, 2021
@e0ne
Use upstream NFD chart
ac62ce4 
NFD charts are merged to NFD repo now so we don't need to duplicate
effort of maintaining charts.

Closes: Mellanox#68
Closes: Mellanox#111

depends-on: kubernetes-ci#104

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use upstream NFD chart e0ne/network-operator
1 participant
@adrianchiris