Use upstream NFD chart #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshe010
reviewed
Apr 3, 2021
|
/retest-nic_operator_helm |
4 similar comments
|
/retest-nic_operator_helm |
|
/retest-nic_operator_helm |
|
/retest-nic_operator_helm |
|
/retest-nic_operator_helm |
|
/retest-all |
1 similar comment
|
/retest-all |
|
CI passed. I'll remove WIP once Mellanox/kubernetes-ci#104 will be merged to not break other PRs |
|
Need to add minimum helm version |
moshe010
reviewed
Apr 9, 2021
Chart.yaml
Outdated
| version: 0.4.0 | ||
| kubeVersion: '>= 1.17.0' | ||
| appVersion: v0.4.0 | ||
| description: Nvidia Mellanox network operator |
There was a problem hiding this comment.
you can remove the Mellanox
Chart.yaml
Outdated
| @@ -0,0 +1,19 @@ | |||
| apiVersion: v2 | |||
There was a problem hiding this comment.
why we need a new Chart.yaml. Don't we have this already in https://github.com/Mellanox/network-operator/blob/master/deployment/network-operator/Chart.yaml
There was a problem hiding this comment.
It was a part of WIP patch. I'll remove it
NFD charts are merged to NFD repo now so we don't need to duplicate effort of maintaining charts. Closes: Mellanox#68 Closes: Mellanox#111 depends-on: kubernetes-ci#104 Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
|
/retest-nic_operator |
2 similar comments
|
/retest-nic_operator |
|
/retest-nic_operator |
moshe010
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFD charts are merged to NFD repo now so we don't need to duplicate
effort of maintaining charts.
Closes: #68
Closes: #111
depends-on: kubernetes-ci#104
Signed-off-by: Ivan Kolodiazhnyi ikolodiazhny@nvidia.com