Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references to CosmosDB memory connector #31

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

JimPaine
Copy link
Contributor

@JimPaine JimPaine commented Aug 3, 2023

CosmosDB connector for Memory Store has been removed and the current docs include broken links and stale information.

PR on SK repo

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 15afa4b:

💡 Validation status: suggestions

File Status Preview URL Details
semantic-kernel/get-started/supported-languages.md 💡Suggestion Details
semantic-kernel/memories/vector-db.md 💡Suggestion Details
semantic-kernel/get-started/quick-start-guide/memory-and-embeddings.md ✅Succeeded

semantic-kernel/get-started/supported-languages.md

  • Line 73, Column 2: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

semantic-kernel/memories/vector-db.md

  • Line 46, Column 2: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit ff9264f:

💡 Validation status: suggestions

File Status Preview URL Details
semantic-kernel/memories/vector-db.md 💡Suggestion Details
semantic-kernel/get-started/quick-start-guide/memory-and-embeddings.md ✅Succeeded
semantic-kernel/get-started/supported-languages.md ✅Succeeded

semantic-kernel/memories/vector-db.md

  • Line 46, Column 2: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 472041a:

✅ Validation status: passed

File Status Preview URL Details
semantic-kernel/get-started/quick-start-guide/memory-and-embeddings.md ✅Succeeded
semantic-kernel/get-started/supported-languages.md ✅Succeeded
semantic-kernel/memories/vector-db.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@JimPaine
Copy link
Contributor Author

JimPaine commented Aug 7, 2023

@dluc @glahaye

Hi both, is it possible for a review on this, the current docs are a little misleading.

@glahaye
Copy link
Contributor

glahaye commented Aug 7, 2023

@JimPaine Thanks for this. Yes, the documentation had not been updated as it should have.

@matthewbolanos matthewbolanos merged commit 1993f3a into MicrosoftDocs:main Aug 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants