.Net: DotNet: Remove cosmosdb memory store #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
added
.NET
shawncal
changed the title
glahaye
approved these changes
Jul 31, 2023
shawncal
approved these changes
Jul 31, 2023
dluc
approved these changes
Jul 31, 2023
|
For future visitors: in future, we might reintroduce CosmosDb support via the MongoDb API that supports vector indexes. For now Azure Cognitive Search and Postgres are the best managed options. |
mkarle
pushed a commit
to mkarle/semantic-kernel
that referenced
this pull request
Aug 2, 2023
### Motivation and Context CosmosDB memory store is an extremely inefficient and expensive to store vectors in cloud storage. If a user wishes to use Azure to host a vector indexing service, existing SK Memory alternatives that we recommend are: - Azure Cognitive Search - Postgres Memory Store - pg vector can be enabled for Azure Database for PostgreSQL https://learn.microsoft.com/en-us/azure/postgresql/flexible-server/how-to-use-pgvector ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Removes CosmosMemoryStore from SK repo. <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Motivation and Context CosmosDB memory store is an extremely inefficient and expensive to store vectors in cloud storage. If a user wishes to use Azure to host a vector indexing service, existing SK Memory alternatives that we recommend are: - Azure Cognitive Search - Postgres Memory Store - pg vector can be enabled for Azure Database for PostgreSQL https://learn.microsoft.com/en-us/azure/postgresql/flexible-server/how-to-use-pgvector ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Removes CosmosMemoryStore from SK repo. <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
CosmosDB memory store is an extremely inefficient and expensive to store vectors in cloud storage.
If a user wishes to use Azure to host a vector indexing service, existing SK Memory alternatives that we recommend are:
Description
Removes CosmosMemoryStore from SK repo.