Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn to omit source in custom profile declaration #191

Merged
merged 3 commits into from
Nov 25, 2020

Conversation

Don-Vito
Copy link
Contributor

If the source field specified for custom profile we fail silently.
Let's start with documenting that this field is not expected in custom profile.
See microsoft/terminal#8333.

@opbld33
Copy link

opbld33 commented Nov 19, 2020

Docs Build status updates of commit d70f135:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/profile-settings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Nov 19, 2020

Docs Build status updates of commit 40de7e1:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/profile-settings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@@ -61,6 +61,9 @@ This stores the name of the profile generator that originated the profile. _Ther

**Accepts:** String

> [!NOTE]
> This field should be omitted when declaring custom profile.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> This field should be omitted when declaring custom profile.
> This field should be omitted when declaring a custom profile. It is used by Terminal to connect automatically generated profiles to your settings file.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks!

@opbld33
Copy link

opbld33 commented Nov 20, 2020

Docs Build status updates of commit 6d32098:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/profile-settings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@DHowett DHowett merged commit 6b53c67 into MicrosoftDocs:master Nov 25, 2020
@DHowett
Copy link
Contributor

DHowett commented Nov 25, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants