-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn to omit source in custom profile declaration #191
Warn to omit source in custom profile declaration #191
Conversation
Docs Build status updates of commit d70f135: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 40de7e1: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@@ -61,6 +61,9 @@ This stores the name of the profile generator that originated the profile. _Ther | |||
|
|||
**Accepts:** String | |||
|
|||
> [!NOTE] | |||
> This field should be omitted when declaring custom profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> This field should be omitted when declaring custom profile. | |
> This field should be omitted when declaring a custom profile. It is used by Terminal to connect automatically generated profiles to your settings file. |
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks!
Docs Build status updates of commit 6d32098: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Thanks! |
If the source field specified for custom profile we fail silently.
Let's start with documenting that this field is not expected in custom profile.
See microsoft/terminal#8333.