Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn to omit source in custom profile declaration #191

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Warn to omit source in custom profile declaration #191

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d70f135
8333: warn to omit source in custom profile declaration
Don-Vito Nov 19, 2020
40de7e1
8333: fix typo
Don-Vito Nov 19, 2020
6d32098
8333: explain why source should not be populated
Don-Vito Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions TerminalDocs/customize-settings/profile-settings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ This stores the name of the profile generator that originated the profile. _Ther

**Accepts:** String

> [!NOTE]
> This field should be omitted when declaring custom profile.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> This field should be omitted when declaring custom profile.
> This field should be omitted when declaring a custom profile. It is used by Terminal to connect automatically generated profiles to your settings file.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks!


### Starting directory

This is the directory the shell starts in when it is loaded.
Expand Down