Feature gate arbitrary-precision from serde_json #18917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quambene-keyrock
requested review from
joyqvq,
kchalkias,
amnn,
wlmyng,
stefan-mysten,
emmazzz,
suiwombat and
patrickkuo
as code owners
|
@quambene is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looking through the git history it seems that this feature was enabled only in the rosetta crate, as a first try lets just try to disable this entirely as is done in #18918 and if that doesn't work for whatever reason we'll only enable this for rosetta. Feature gating as is done in this PR is not ideal and imo not maintainable for the workspace of our size |
|
Closing in favor of #18918 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Features in Rust are "infectious". In particular, the
arbitrary-precisionfeature ofserde_jsonis leading to issues downstream because of the known bugs:serde(tag = ..)andserde(flatten)serde-rs/json#505serde-arbitrary-precisionwithoutserde-floatpaupino/rust-decimal#602Therefore, my suggestion is to feature gate
arbitrary-precisionas done in this PR.Test plan
How did you test the new or updated feature?
cargo checkwas run successfully.Release notes
It affects crates which have
serde_jsonas dependency and which are using it from the workspace.Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.