MystenLabs · quambene-keyrock · Aug 6, 2024 · Aug 6, 2024 · Aug 6, 2024 · Aug 7, 2024
diff --git a/Cargo.toml b/Cargo.toml
@@ -443,9 +443,15 @@ serial_test = "2.0.0"
 serde = { version = "1.0.144", features = ["derive", "rc"] }
 serde-name = "0.2.1"
 serde-reflection = "0.3.6"
+# The `arbitrary-precision` feature for `serde_json` shouldn't be enabled on
+# workspace-level because of the known bugs
+# - https://github.com/serde-rs/serde/issues/1183
+# - https://github.com/serde-rs/json/issues/505
+# - https://github.com/paupino/rust-decimal/issues/602
+# which could lead to issues downstream. Instead, it should be feature-gated on
+# crate-level.
 serde_json = { version = "1.0.95", features = [
   "preserve_order",
-  "arbitrary_precision",
 ] }
 serde_repr = "0.1"
 serde_test = "1.0.147"

diff --git a/crates/sui-analytics-indexer/Cargo.toml b/crates/sui-analytics-indexer/Cargo.toml
@@ -60,3 +60,6 @@ tap.workspace = true
 [[bin]]
 name = "sui-analytics-indexer"
 path = "src/main.rs"
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-aws-orchestrator/Cargo.toml b/crates/sui-aws-orchestrator/Cargo.toml
@@ -39,3 +39,6 @@ tempfile = "3.6.0"
 [[bin]]
 name = "sui-aws-orchestrator"
 path = "src/main.rs"
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-benchmark/Cargo.toml b/crates/sui-benchmark/Cargo.toml
@@ -58,3 +58,4 @@ typed-store.workspace = true
 
 [features]
 benchmark = ["narwhal-node/benchmark"]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-bridge-cli/Cargo.toml b/crates/sui-bridge-cli/Cargo.toml
@@ -27,3 +27,6 @@ serde_json.workspace = true
 telemetry-subscribers.workspace = true
 reqwest.workspace = true
 futures.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-bridge/Cargo.toml b/crates/sui-bridge/Cargo.toml
@@ -56,3 +56,6 @@ sui-test-transaction-builder.workspace = true
 test-cluster.workspace = true
 hex-literal = "0.3.4"
 maplit = "1.0.2"
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-cluster-test/Cargo.toml b/crates/sui-cluster-test/Cargo.toml
@@ -47,3 +47,4 @@ move-core-types.workspace = true
 default = ["postgres-feature"]
 postgres-feature = ["diesel/postgres", "diesel/postgres_backend"]
 pg_integration = []
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-core/Cargo.toml b/crates/sui-core/Cargo.toml
@@ -146,3 +146,4 @@ harness = false
 
 [features]
 test-utils = []
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-data-ingestion-core/Cargo.toml b/crates/sui-data-ingestion-core/Cargo.toml
@@ -32,3 +32,6 @@ sui-rest-api.workspace = true
 [dev-dependencies]
 rand.workspace = true
 sui-types = { workspace = true, features = ["test-utils"] }
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-data-ingestion/Cargo.toml b/crates/sui-data-ingestion/Cargo.toml
@@ -38,3 +38,6 @@ url.workspace = true
 rand.workspace = true
 tempfile.workspace = true
 sui-types = { workspace = true, features = ["test-utils"] }
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-e2e-tests/Cargo.toml b/crates/sui-e2e-tests/Cargo.toml
@@ -67,4 +67,7 @@ passkey-client.workspace = true
 passkey-authenticator.workspace = true
 coset.workspace = true
 url.workspace = true
-p256.workspace = true
+p256.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-framework-snapshot/Cargo.toml b/crates/sui-framework-snapshot/Cargo.toml
@@ -20,3 +20,6 @@ sui-types.workspace = true
 
 [dev-dependencies]
 tokio = { workspace = true, features = ["full"] }
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-graphql-rpc-client/Cargo.toml b/crates/sui-graphql-rpc-client/Cargo.toml
@@ -14,3 +14,6 @@ reqwest.workspace = true
 serde_json.workspace = true
 sui-graphql-rpc-headers.workspace = true
 thiserror.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
@@ -98,3 +98,4 @@ default = ["pg_backend", "postgres-feature"]
 postgres-feature = ["diesel/postgres", "diesel/postgres_backend"]
 pg_integration = []
 pg_backend = []
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-indexer/Cargo.toml b/crates/sui-indexer/Cargo.toml
@@ -63,6 +63,7 @@ pg_integration = []
 default = ["postgres-feature"]
 postgres-feature = ["diesel/postgres", "diesel/postgres_backend", "diesel-derive-enum/postgres"]
 mysql-feature = ["diesel/mysql", "diesel/mysql_backend", "diesel-derive-enum/mysql"]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
 
 [dev-dependencies]
 sui-keys.workspace = true

diff --git a/crates/sui-json-rpc-types/Cargo.toml b/crates/sui-json-rpc-types/Cargo.toml
@@ -38,3 +38,4 @@ sui-types = { workspace = true, features = ["test-utils"] }
 
 [features]
 test-utils = []
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-json-rpc/Cargo.toml b/crates/sui-json-rpc/Cargo.toml
@@ -61,3 +61,6 @@ mockall.workspace = true
 expect-test.workspace = true
 sui-types = { workspace = true, features = ["test-utils"] }
 telemetry-subscribers.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
@@ -22,3 +22,6 @@ regex.workspace = true
 
 [dev-dependencies]
 tempfile.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-light-client/Cargo.toml b/crates/sui-light-client/Cargo.toml
@@ -26,3 +26,5 @@ move-binary-format.workspace = true
 sui-json-rpc-types.workspace = true
 sui-package-resolver.workspace = true
 
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-move/Cargo.toml b/crates/sui-move/Cargo.toml
@@ -66,3 +66,4 @@ prove = []
 unit_test = ["build", "dep:once_cell"]
 calibrate = []
 all = ["build", "coverage", "disassemble", "prove", "unit_test", "calibrate"]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-open-rpc/Cargo.toml b/crates/sui-open-rpc/Cargo.toml
@@ -33,3 +33,6 @@ move-core-types.workspace = true
 name = "generate-json-rpc-spec"
 path = "src/generate_json_rpc_spec.rs"
 test = false
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-package-resolver/Cargo.toml b/crates/sui-package-resolver/Cargo.toml
@@ -32,3 +32,6 @@ move-compiler.workspace = true
 serde_json.workspace = true
 sui-move-build.workspace = true
 tower.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-proxy/Cargo.toml b/crates/sui-proxy/Cargo.toml
@@ -54,3 +54,6 @@ sui-types = { workspace = true, features = ["test-utils"] }
 
 [build-dependencies]
 prost-build.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-replay/Cargo.toml b/crates/sui-replay/Cargo.toml
@@ -51,3 +51,6 @@ sui-sdk.workspace = true
 sui-storage.workspace = true
 sui-transaction-checks.workspace = true
 sui-types.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-rest-api/Cargo.toml b/crates/sui-rest-api/Cargo.toml
@@ -31,6 +31,8 @@ sui-types.workspace = true
 mysten-network.workspace = true
 sui-protocol-config.workspace = true
 
-
 [dev-dependencies]
 diffy = "0.3"
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-rosetta/Cargo.toml b/crates/sui-rosetta/Cargo.toml
@@ -49,3 +49,6 @@ test-cluster.workspace = true
 tempfile.workspace = true
 rand.workspace = true
 reqwest.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-rpc-loadgen/Cargo.toml b/crates/sui-rpc-loadgen/Cargo.toml
@@ -39,3 +39,6 @@ test-cluster.workspace = true
 [[bin]]
 name = "sui-rpc-loadgen"
 path = "src/main.rs"
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-sdk/Cargo.toml b/crates/sui-sdk/Cargo.toml
@@ -48,6 +48,10 @@ futures-core.workspace = true
 futures.workspace = true
 rand.workspace = true
 
+[features]
+default = []
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
+
 [[example]]
 name = "coin_read_api"
 path = "examples/coin_read_api.rs"

diff --git a/crates/sui-security-watchdog/Cargo.toml b/crates/sui-security-watchdog/Cargo.toml
@@ -25,3 +25,6 @@ uuid.workspace = true
 lexical-util = "0.8.5"
 reqwest = { workspace = true, features = ["json"] }
 env_logger = "0.11.3"
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-single-node-benchmark/Cargo.toml b/crates/sui-single-node-benchmark/Cargo.toml
@@ -37,3 +37,6 @@ tracing.workspace = true
 sui-macros.workspace = true
 sui-protocol-config.workspace = true
 sui-simulator.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-snapshot/Cargo.toml b/crates/sui-snapshot/Cargo.toml
@@ -33,3 +33,6 @@ serde_json.workspace = true
 
 [dev-dependencies]
 tempfile.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-storage/Cargo.toml b/crates/sui-storage/Cargo.toml
@@ -64,3 +64,6 @@ sui-test-transaction-builder.workspace = true
 sui-types = { workspace = true, features = ["test-utils"] }
 sui-macros = { workspace = true }
 sui-simulator = { workspace = true }
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-tool/Cargo.toml b/crates/sui-tool/Cargo.toml
@@ -51,3 +51,6 @@ sui-storage.workspace = true
 sui-types.workspace = true
 sui-archival.workspace = true
 bin-version.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-transactional-test-runner/Cargo.toml b/crates/sui-transactional-test-runner/Cargo.toml
@@ -54,3 +54,6 @@ typed-store.workspace = true
 
 [target.'cfg(msim)'.dependencies]
 msim.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui-types/Cargo.toml b/crates/sui-types/Cargo.toml
@@ -105,3 +105,4 @@ gas-profiler = [
     "move-vm-test-utils/gas-profiler",
 ]
 fuzzing = ["move-core-types/fuzzing"]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/sui/Cargo.toml b/crates/sui/Cargo.toml
@@ -132,3 +132,4 @@ gas-profiler = [
     "sui-execution/gas-profiler",
 ]
 indexer = ["dep:sui-indexer", "dep:sui-graphql-rpc"]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/suins-indexer/Cargo.toml b/crates/suins-indexer/Cargo.toml
@@ -38,3 +38,6 @@ mysten-service.workspace = true
 rand.workspace = true
 tempfile.workspace = true
 sui-types = { workspace = true, features = ["test-utils"] }
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/crates/suiop-cli/Cargo.toml b/crates/suiop-cli/Cargo.toml
@@ -52,3 +52,6 @@ tracing.workspace = true
 
 [dev-dependencies]
 tempfile.workspace = true
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/external-crates/move/crates/move-analyzer/Cargo.toml b/external-crates/move/crates/move-analyzer/Cargo.toml
@@ -40,3 +40,5 @@ datatest-stable.workspace = true
 name = "ide_testsuite"
 harness = false
 
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/external-crates/move/crates/move-binary-format/Cargo.toml b/external-crates/move/crates/move-binary-format/Cargo.toml
@@ -34,3 +34,4 @@ serde_json.workspace = true
 default = []
 fuzzing = ["proptest", "proptest-derive", "arbitrary", "move-core-types/fuzzing"]
 wasm = ["getrandom"]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/external-crates/move/crates/move-compiler/Cargo.toml b/external-crates/move/crates/move-compiler/Cargo.toml
@@ -44,3 +44,6 @@ datatest-stable.workspace = true
 [[test]]
 name = "move_check_testsuite"
 harness = false
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/external-crates/move/crates/move-core-types/Cargo.toml b/external-crates/move/crates/move-core-types/Cargo.toml
@@ -40,3 +40,4 @@ arbitrary = { workspace = true, features = ["derive_arbitrary"] }
 [features]
 default = []
 fuzzing = ["proptest", "proptest-derive", "arbitrary"]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/external-crates/move/crates/move-ir-compiler/Cargo.toml b/external-crates/move/crates/move-ir-compiler/Cargo.toml
@@ -25,3 +25,4 @@ bcs.workspace = true
 
 [features]
 default = []
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/external-crates/move/crates/move-symbol-pool/Cargo.toml b/external-crates/move/crates/move-symbol-pool/Cargo.toml
@@ -19,3 +19,4 @@ serde_json.workspace = true
 
 [features]
 default = []
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/external-crates/move/crates/move-vm-profiler/Cargo.toml b/external-crates/move/crates/move-vm-profiler/Cargo.toml
@@ -16,3 +16,4 @@ move-vm-config.workspace = true
 
 [features]
 gas-profiler = ["move-vm-config/gas-profiler"]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
diff --git a/narwhal/config/Cargo.toml b/narwhal/config/Cargo.toml
@@ -25,3 +25,6 @@ rand.workspace = true
 tempfile.workspace = true
 
 test-utils = { path = "../test-utils", package = "narwhal-test-utils" }
+
+[features]
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
@@ -14,6 +14,8 @@ bcs.workspace = true
 
 [features]
 default = []
+serde-arbitrary-precision = ["serde_json/arbitrary_precision"]
+
 [dev-dependencies]
 bincode.workspace = true
 criterion.workspace = true