Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable VS Code usage via code-server #19

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Enable VS Code usage via code-server #19

merged 3 commits into from
Aug 7, 2024

Conversation

maxrjones
Copy link
Collaborator

@maxrjones maxrjones commented Aug 1, 2024

This PR partly addresses https://github.com/NASA-IMPACT/veda-analytics/issues/117 by adding code-server and installing VS Code extensions using the approach proposed in https://github.com/NASA-IMPACT/veda-analytics/issues/117#issuecomment-2259214346.

@batpad
Copy link
Collaborator

batpad commented Aug 2, 2024

Thanks for this @maxrjones !

@sunu would you be able to help review?

@yuvipanda I'd love to get your thoughts on whether we should include things like this in the default image. There's also #20 to enable Jupyter RTC. It seems to me like having separate images starts leading to a lot of permutations and combinations and I think that it would be nice to have better VS Code integration and the ability to do real-time collaboration just in the default image?

And, this seems different enough for the base pangeo image use-case that we shouldn't upstream into the pangeo image, so this seems like a good place for it?

I don't have any strong opinions here - if you feel like it's better to create separate images for these use-cases, we can do that as well and include it in the profile image selection drop-down.

Thanks @maxrjones ! I merged your fix for the failing test in #21 so hopefully rebasing on main will fix the failing test.

@batpad
Copy link
Collaborator

batpad commented Aug 2, 2024

@maxrjones once this image is getting pushed successfully, could you write a quick "how to test this".

@sunu
Copy link
Collaborator

sunu commented Aug 2, 2024

@batpad I tested this locally with the following steps:

  1. Checked out the branch locally and built the image:
git checkout vscode
docker build -t veda-vscode .
  1. Started a jupyterlab instance using the built image:
docker run -it -p 8888:8888 --security-opt seccomp=unconfined veda-vscode jupyter lab
  1. Opened the home page and clicked on the vscode launcher which opened a functional vscode instance for me.
  2. I clicked on the "extensions" icon on the left sidebar of the VS Code instance and it listed all the installed extensions.

@yuvipanda
Copy link
Contributor

Ya, i think it's fine to add this here. We should also figure out how to support this upstream (probably becomes an image variant), but is fine here. same with jupyter_collaboration.

@batpad batpad merged commit 71840bc into main Aug 7, 2024
2 checks passed
@maxrjones maxrjones deleted the vscode branch August 7, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants