Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyter-collaboration via conda-forge #20

Closed
wants to merge 5 commits into from
Closed

Add jupyter-collaboration via conda-forge #20

wants to merge 5 commits into from

Conversation

maxrjones
Copy link
Collaborator

This PR adds the jupyter-collaboration extension to the pangeo-notebook-veda image. I tested that this approach does create a new panel for the extension. The next step is to test on staging in real-time.

Part of https://github.com/NASA-IMPACT/veda-analytics/issues/118

image

@maxrjones maxrjones requested a review from batpad August 1, 2024 22:29
@maxrjones
Copy link
Collaborator Author

Ah, on the failing tests I think I remember something about the API Gateway being moved. I'll look into that.

@batpad
Copy link
Collaborator

batpad commented Aug 2, 2024

@maxrjones rebasing main should fix the test, and then we should have an image created that we can test with on Monday. cc @sunu

Am quite excited about testing this out, thanks for the PR!

@maxrjones
Copy link
Collaborator Author

@maxrjones rebasing main should fix the test, and then we should have an image created that we can test with on Monday. cc @sunu

Am quite excited about testing this out, thanks for the PR!

Thanks for merging #21! I rebased the two open PRs.

P.s., I won't mind if you ever want to push to my PRs in this repo, given the time zone differences it might make things easier but up to you

@batpad
Copy link
Collaborator

batpad commented Aug 5, 2024

@maxrjones sorry for the meaningless commits here - was just trying to debug why CI was not pushing images to ECR .. still unclear why that's happening but hoping it's something transient on the GH actions side.

@batpad
Copy link
Collaborator

batpad commented Aug 5, 2024

@maxrjones am not sure how to test this ..

I managed to get an image with the plugin installed public.ecr.aws/nasa-veda/pangeo-notebook-veda-image:481da9b2e071 and I get the plugin showing up, but am not sure what URL to share / how this is supposed to work when running on Jupyterhub? We might need to do some additional config / something like https://jupyterhub.readthedocs.io/en/stable/tutorial/collaboration-users.html ?

@maxrjones happy to chat to figure out what next steps are here to configure things on the hub.

@batpad
Copy link
Collaborator

batpad commented Sep 6, 2024

This seems like it's going to take a bit more work to get working inside the JupyterHub environment. There's active streams of work to enable this and I'd love to take this on as an Objective for next PI.

@maxrjones I'm going to close this PR as is, but please feel free to re-open.

@batpad batpad closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants