Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token to codecov upload #566

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Add token to codecov upload #566

merged 3 commits into from
Feb 27, 2024

Conversation

anissa111
Copy link
Member

@anissa111 anissa111 commented Feb 27, 2024

PR Summary

Closes #565

So, I'm not entirely sure how to test this because the failures only come from main on the NCAR/geocat-comp repo.

I followed this documentation from Codevoc: Adding the Codecov Token

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@anissa111 anissa111 added bug Something isn't working developer feature For development standardization / best practices / enhancement testing Issue related to testing labels Feb 27, 2024
@anissa111 anissa111 marked this pull request as ready for review February 27, 2024 17:01
@anissa111 anissa111 merged commit d61ec65 into NCAR:main Feb 27, 2024
15 checks passed
@anissa111 anissa111 deleted the codecov_token branch February 27, 2024 17:56
@anissa111
Copy link
Member Author

It worked 🎉 https://app.codecov.io/gh/NCAR/geocat-comp/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working developer feature For development standardization / best practices / enhancement testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov failures February 26 2024
2 participants