Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coil:Cooling:DX:CurveFit:OperatingMode: Nominal Evaporative Condenser Pump Power is marked autosizabled, but not autosized #8066

Closed
2 of 3 tasks
jmarrec opened this issue Jun 9, 2020 · 2 comments · Fixed by #8247
Assignees
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@jmarrec
Copy link
Contributor

jmarrec commented Jun 9, 2020

Issue overview

Implementing this object in OpenStudio, I was checking the SQL file to find the entry for Nominal Evaporative Condenser Pump Power but couldn't find it.

From the IDD:

Coil:Cooling:DX:CurveFit:OperatingMode,
  [...]
   N8, \field Nominal Evaporative Condenser Pump Power
       \note Rated power consumed by the evaporative condenser's water pump
       \type real
       \units W
       \minimum 0.0
       \default 0.0
       \autosizable

Yet, CoilCoolingDXCurveFitOperatingMode::size does not autosize this one, but correctly autosizes the other 3 autosizable fields this object has:

void CoilCoolingDXCurveFitOperatingMode::size(EnergyPlusData &state)
{
std::string RoutineName = "sizeOperatingMode";
std::string CompType = this->object_name;
std::string CompName = this->name;
bool PrintFlag = true;
int SizingMethod = DataHVACGlobals::CoolingAirflowSizing;
std::string SizingString = "Rated Evaporator Air Flow Rate";
Real64 TempSize = this->original_input_specs.rated_evaporator_air_flow_rate;
ReportSizingManager::RequestSizing(state, CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
this->ratedEvapAirFlowRate = TempSize;
Real64 const ratedInletAirTemp(26.6667); // 26.6667C or 80F
Real64 const ratedInletAirHumRat(0.01125); // Humidity ratio corresponding to 80F dry bulb/67F wet bulb
this->ratedEvapAirMassFlowRate = this->ratedEvapAirFlowRate * Psychrometrics::PsyRhoAirFnPbTdbW(
DataEnvironment::StdBaroPress, ratedInletAirTemp, ratedInletAirHumRat, RoutineName);
SizingMethod = DataHVACGlobals::CoolingCapacitySizing;
SizingString = "Rated Gross Total Cooling Capacity";
DataSizing::DataFlowUsedForSizing = this->ratedEvapAirFlowRate; // TODO: This is volume flow, right?
TempSize = this->original_input_specs.gross_rated_total_cooling_capacity;
ReportSizingManager::RequestSizing(state, CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
this->ratedGrossTotalCap = TempSize;
SizingMethod = DataHVACGlobals::AutoCalculateSizing;
// Auto size condenser air flow to Total Capacity * 0.000114 m3/s/w (850 cfm/ton)
DataSizing::DataConstantUsedForSizing = this->ratedGrossTotalCap;
DataSizing::DataFractionUsedForSizing = 0.000114;
SizingString = "Rated Condenser Air Flow Rate";
TempSize = this->original_input_specs.rated_condenser_air_flow_rate;
ReportSizingManager::RequestSizing(state, CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
this->ratedCondAirFlowRate = TempSize;
for (auto &curSpeed : this->speeds) {
curSpeed.parentModeRatedGrossTotalCap = this->ratedGrossTotalCap;
curSpeed.parentModeRatedEvapAirFlowRate = this->ratedEvapAirFlowRate;
curSpeed.parentModeRatedCondAirFlowRate = this->ratedCondAirFlowRate;
curSpeed.size(state);
}
}

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version): All
  • Version of EnergyPlus (if using an intermediate build, include SHA): E+ 9.4 in progress, at 431d527
  • Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@jmarrec jmarrec added the Defect Includes code to repair a defect in EnergyPlus label Jun 9, 2020
jmarrec added a commit to NREL/OpenStudio that referenced this issue Jun 9, 2020
@jmarrec
Copy link
Contributor Author

jmarrec commented Aug 27, 2020

Additionally, the other three don't have any units in the SQL output.

image

That's an easy fix.

@mjwitte
Copy link
Contributor

mjwitte commented Aug 27, 2020

@jmarrec There are some pending changes to Coil:Cooling:DX in #8204 but I don't see the evap condenser pump power sizing there.

jmarrec added a commit that referenced this issue Sep 2, 2020
jmarrec added a commit that referenced this issue Sep 2, 2020
jmarrec added a commit that referenced this issue Sep 2, 2020
…s are properly registered

Note: I made CoilCoolingDXFixture inherit SQLiteFixture instead of EnergyPlusFixture
jmarrec added a commit that referenced this issue Sep 2, 2020
Myoldmopar added a commit that referenced this issue Sep 16, 2020
Fix #8066 - Coil:Cooling:DX:CurveFit:OperatingMode: Nominal Evaporative Condenser Pump Power is marked autosizabled, but not autosized, and other autosized missing units
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
2 participants