Coil:Cooling:DX updates - old

[mjwitte]

Pull request overview

This PR superseded by #8292

Fill in feature gaps and clean up Coil:Cooling:DX, including:

• Standard ratings
• Additional output variables
• Doc updates
• Unitary system setpoint control
• Coil selection reporting
• Single mode and 100% OA mode
• Latent degradation
• Fix basin heater operating schedule name input
• Fixes DX Coil Crankcase Heater Electricity Submeter Shouldn't be on Plant #7254 basin heater metering.

Still needs work:

• User vs std ratings (from Add Report of SEER calculated using the user specified PLF curve and default AHRI curve and C_D #7821 )
• Fix some failing unit tests - did something get broken, or are the test comparison values just outdated?
• Fix 2-speed with cycling fan (and maybe others? - need to quantify this issue better).
• Should Condenser flow rate default to autosize? (This IDD change would have to wait, but noting it here so it's not forgotten.)

Diffs vs CoilBaselineFeb2020Aug2020

File	Sizing Diffs	DesignDay eso Diffs	DesignDay mtr Diffs	Annual eso Diffs	Annual mtr Diffs	Err Diffs
UnitarySystem_DXCoilSystemAuto	None	None	None	Small	Small	N
UnitarySystem_FurnaceWithDXSystemRHcontrol	None	Big - FURNACE HEATING COIL 1:Heating Coil Heating Rate [W]	Small	Big	Small	N
UnitarySystem_HeatPumpAuto	None	Big - DXAC HEAT PUMP 1:Unitary System Compressor Part Load Ratio	None	Big	Small	N
UnitarySystem_MultiSpeedCoils_SingleMode	Small	Big - HEAT PUMP ACDXCOIL 2:Cooling Coil Total Cooling Energy [J]	Big	Big	Big	Y
UnitarySystem_MultiSpeedDX	Small	Big - SYS 1 FURNACE DX COOL COOLING COIL:Cooling Coil Total Cooling Rate [W	Big	Big	Big	N
UnitarySystem_SingleSpeedDX	None	Small	Small	Small	Small	N
UnitarySystem_TwoSpeedDX	None	Big	Big	Big	Big	N
UnitarySystem_TwoStageDX	None	Big	Big	Big	Big	Y
UnitarySystem_TwoStageDXWithHumidityControl	None	Big	Big	Big	Big	Y
UnitarySystem_VSCoolingCoil	Big	Big	Big	Big	Big	Y

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

I think that this is closed the, right? Closing now but obviously reopen as needed.

[mjwitte]

Yes, fine to close this, but I'm still comparing against it to make sure the (messy) merge process didn't break anything.

[Myoldmopar]

For sure, not deleting anything, just getting it out of the PR list.