Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance outdoor air tabular reporting-superseded by 8529 #7629

Closed
wants to merge 58 commits into from

Conversation

JasonGlazer
Copy link
Contributor

@JasonGlazer JasonGlazer commented Nov 20, 2019

Pull request overview

This PR has been superseded by #8529.

Currently, users seeking to use EnergyPlus for LEED work need to document the use of Outdoor Air (OA) in their models. While the current Outdoor Air Summary in EnergyPlus provides some information to help these users, it does not provide enough information. Users often find it difficult to compare the OA delivered for proposed vs. baseline simulations, especially with economizers and zone equipment. This new feature will enhance the Outdoor Air Summary tabular report to include zone HVAC equipment, add tracking and table outputs for minimum requested outdoor air flow, track times when the delivered outdoor air is less than the minimum required and provide outputs in standard air density.

The needs of this enhancement were discussed in issue #5298

The new feature proposal provides further detail.

Resolves #5298.
Resolves #5846 (final piece)

Unfinished business from this PR is documented in #8550

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@JasonGlazer JasonGlazer added the NewFeature Includes code to add a new feature to EnergyPlus label Nov 20, 2019
@nrel-bot-3
Copy link

@JasonGlazer @lgentile it has been 28 days since this pull request was last updated.

@mjwitte mjwitte added the OutputChange Code changes output in such a way that it cannot be merged after IO freeze label Jan 14, 2020
@mjwitte mjwitte added this to the EnergyPlus Future milestone Jan 23, 2020
@nrel-bot-2b
Copy link

@JasonGlazer @lgentile it has been 28 days since this pull request was last updated.

@nrel-bot-2
Copy link

@JasonGlazer it has been 13 days since this pull request was last updated.

@nrel-bot-2b
Copy link

@JasonGlazer it has been 7 days since this pull request was last updated.

1 similar comment
@nrel-bot-2c
Copy link

@JasonGlazer it has been 7 days since this pull request was last updated.

@nrel-bot
Copy link

@JasonGlazer @lgentile it has been 28 days since this pull request was last updated.

1 similar comment
@nrel-bot
Copy link

@JasonGlazer @lgentile it has been 28 days since this pull request was last updated.

@mjwitte mjwitte changed the title Enhance outdoor air tabular reporting Enhance outdoor air tabular reporting-superseded by 8529 Feb 15, 2021
@mjwitte mjwitte closed this Feb 15, 2021
@mjwitte mjwitte deleted the EnhanceOutdoorAirReporting branch February 20, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Includes code to add a new feature to EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OA controller economizer schedule and min OA flow autosizing Outdoor Air Summary report improvements
8 participants