Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan ruby: Windows build no longer works on Windows2022 github runner #5223

Open
jmarrec opened this issue Jun 17, 2024 · 0 comments · May be fixed by #5224
Open

Conan ruby: Windows build no longer works on Windows2022 github runner #5223

jmarrec opened this issue Jun 17, 2024 · 0 comments · May be fixed by #5224
Labels
component - Conan Dependency / Package manager problems component - Ruby bindings

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Jun 17, 2024

Issue overview

Reported by @macumber at:

Filed on the conan-recipes repo at:

jmarrec/conan-recipes#9

Current Behavior

After update to Windows2022 github runner, actions/runner-images@a615999#diff-d3119a278ce9ce80fc4b5af63a1112fb3a044aec3e6002d838e8eb26d7a3a499L223, the MSC_VER is no longer compatible with that in the conan ruby recipe ruby9af7e8c0a7cea\p\include\ruby-3.2.0\x64-mswin64_140\ruby\config.h

#if (_MSC_VER < 1920) || (_MSC_VER > 1939)
#error MSC version unmatch: 1920..1939 is expected.
#endif

I think Ruby is overly restrictive here and the right thing to do is probably patch it to remove this error

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudio (if using an intermediate build, include SHA):

Context

@jmarrec jmarrec added component - Ruby bindings component - Conan Dependency / Package manager problems labels Jun 17, 2024
jmarrec added a commit that referenced this issue Jun 17, 2024
Note: the armv8 macos14 builds failed, and I don't understand why... So maybe we'll need to figure that out...
@jmarrec jmarrec linked a pull request Jun 17, 2024 that will close this issue
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - Conan Dependency / Package manager problems component - Ruby bindings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant