Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build no longer works on Windows2022 github runner #719

Closed
macumber opened this issue Jun 15, 2024 · 2 comments
Closed

Windows build no longer works on Windows2022 github runner #719

macumber opened this issue Jun 15, 2024 · 2 comments

Comments

@macumber
Copy link
Collaborator

macumber commented Jun 15, 2024

Issue overview

After update to Windows2022 github runner, actions/runner-images@a615999#diff-d3119a278ce9ce80fc4b5af63a1112fb3a044aec3e6002d838e8eb26d7a3a499L223, the MSC_VER is no longer compatible with that in the conan ruby recipe ruby9af7e8c0a7cea\p\include\ruby-3.2.0\x64-mswin64_140\ruby\config.h

#if (_MSC_VER < 1920) || (_MSC_VER > 1939)
#error MSC version unmatch: 1920..1939 is expected.
#endif

I think Ruby is overly restrictive here and the right thing to do is probably patch it to remove this error

#if (_MSC_VER < 1920) || (_MSC_VER > 1939)
//#error MSC version unmatch: 1920..1939 is expected.
#endif

Current Behavior

Build fails https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/9472307795/job/26104804025?pr=718

Expected Behavior

Build should succeed

Steps to Reproduce

Run CI action with Windows2022 runner

Possible Solution

Downgrade to Windows2019 (short term), patch ruby (longer term)

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): Windows
@macumber
Copy link
Collaborator Author

@jmarrec FYI

@macumber
Copy link
Collaborator Author

I tried adding this on our side but it does not work.

#if (_MSC_VER > 1939)
  #define T(a) #a
  #define S(a) T(a)
  #pragma message( "The 0 value of _MSC_VER: " S(_MSC_VER) )
  #pragma push_macro("_MSC_VER")
  #undef _MSC_VER
  #define _MSC_VER 1939
  #pragma message( "The 1 value of _MSC_VER: " S(_MSC_VER) )
  #include <ruby.h>
  #pragma pop_macro("_MSC_VER")
  #pragma message( "The 2 value of _MSC_VER: " S(_MSC_VER) )
#else
  #include <ruby.h>
#endif

macumber added a commit that referenced this issue Jun 22, 2024
* Update floorspace

* Temporarily downgrade to Windows2019 runner as work around to #719

* Update windows matrix

* Attempt to fix Mac

* Try cleaning self hosted between runs

* Revert back to 2022 Windows Runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant