Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4] Add secure federated xgboost example #2649

Closed
wants to merge 3 commits into from

Conversation

ZiyueXu77
Copy link
Collaborator

Fixes # .

Description

Add the same secure xgboost example to 2.4

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@ZiyueXu77 ZiyueXu77 requested a review from nvidianz June 15, 2024 00:56
@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77 ZiyueXu77 enabled auto-merge (squash) June 15, 2024 01:02
@YuanTingHsieh YuanTingHsieh changed the title Add secure federated xgboost example [2.4] Add secure federated xgboost example Jun 17, 2024
Comment on lines +15 to +18
import matplotlib.pyplot as plt
import pandas as pd
import shap
import xgboost as xgb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add these into requirements.txt

f.write(tree)

# plot tree and save to png file
xgb.plot_tree(bst, num_trees=0, rankdir="LR")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to install graphviz

Comment on lines +1 to +2
#!/usr/bin/env bash
mkdir /tmp/nvflare/xgb_exp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest add a check to check if not exist then create

@YuanTingHsieh
Copy link
Collaborator

changes are already included in #2673

And we should move all the required changes into #2686

auto-merge was automatically disabled July 15, 2024 20:10

Pull request was closed

@ZiyueXu77 ZiyueXu77 deleted the secureboost_2.4 branch July 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants