Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Secure XGBoost example w.r.t. XGBoost's code changes #2686

Merged
merged 54 commits into from
Aug 13, 2024

Conversation

ZiyueXu77
Copy link
Collaborator

Fixes # .

Description

Update NVFlare's secure XGB example according to latest XGB code changes

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Copy link
Collaborator

Please also take any changes in #2673 that is necessary, thanks

@ZiyueXu77 ZiyueXu77 marked this pull request as ready for review August 12, 2024 15:30
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77 ZiyueXu77 merged commit 622f205 into NVIDIA:main Aug 13, 2024
15 of 16 checks passed
@ZiyueXu77 ZiyueXu77 deleted the secureboost branch August 13, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants