Use BasicColumnarWriteTaskStats instead of BasicWriteTaskStats #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
revans2
approved these changes
Oct 22, 2020
|
The testes failed with a new error that looks like it is related to Looks like RegexpReplace needs to be added to the shim layer now. |
|
Looking at it we can probably get away with just the replacement rule for RegexpReplace being in the shim layer. They added in a new position argument. In 3.1+ we should verify that position is a literal that is 1 and then just ignore it when we replace it. We should also file a follow on issue to eventually support it properly. |
|
This was merged/fixed as a part of #1012 |
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1009) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the plugin build against Spark 3.1.0 by using a custom
BasicColumnarWriteTaskStatscase class instead of trying to reuse Spark'sBasicWriteTaskStatswhich recently changed in Spark 3.1.0.Fixes #1006