Update for new position parameter in Spark 3.1.0 RegExpReplace #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
revans2
approved these changes
Oct 23, 2020
|
Note that this should not be committed with a squash commit since it is based on the other PR. We should either force-merge the other PR first then this one, or merge this with a rebase to preserve the separate commits. |
|
Filed #1013 to track supporting more values than just 1 for the position parameter. |
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…#1012) Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark 3.1.0 added a new search start position parameter to the
RegExpReplaceexpression. This moves the rule forRegExpReplaceinto the shims and updates the 3.1.0 version to only allow conversion to the GPU if the start position is foldable and evaluates to 1.This is based upon the fix in #1009 to get the build to pass.