Fix scalar leak in RankFixer #10475
Merged
Fix scalar leak in RankFixer #10475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
| @@ -1711,6 +1711,7 @@ class RankFixer extends BatchedRunningWindowFixer with Logging { | |||
| override def close(): Unit = { | |||
| previousRank.foreach(_.close()) | |||
There was a problem hiding this comment.
Should we also change?
Suggested change
| previousRank.foreach(_.close()) | |
| previousRank.foreach(_.safeClose()) |
There was a problem hiding this comment.
Ah, it turns out that cudf.Scalar objects cannot be safeClose()d:
Error: ] /home/runner/work/spark-rapids/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/window/GpuWindowExpression.scala:1712: value safeClose is not a member of ai.rapids.cudf.Scalar
2345
Error: [ERROR] one error found
Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>
|
build |
mythrocks
previously approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Yikes. Good catch. Thanks for finding this, @jlowe.
P.S. I think this should be safe to check in after we revert the safeClose change. @gerashegalov, does that sound agreeable?
Signed-off-by: Gera Shegalov <gera@apache.org>
|
@mythrocks it just needs an RapidsPluginImplicits import |
|
build |
mythrocks
approved these changes
Feb 23, 2024
|
Thanks for the import fix, @gerashegalov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10473. Updates the RankFixer.close() method to close the BatchedRunningWindowBinaryFixer instance which is caching a scalar.