Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scalar leak in RankFixer #10475

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Fix scalar leak in RankFixer #10475

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e045288
Fix scalar leak in RankFixer
jlowe Feb 22, 2024
b4e040e
Use safeClose
jlowe Feb 22, 2024
e65116b
Add missing RapidsPluginImplicits import
gerashegalov Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sql-plugin/src/main/scala/com/nvidia/spark/rapids/window/GpuWindowExpression.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import com.nvidia.spark.Retryable
import com.nvidia.spark.rapids._
import com.nvidia.spark.rapids.Arm.{closeOnExcept, withResource}
import com.nvidia.spark.rapids.GpuOverrides.wrapExpr
import com.nvidia.spark.rapids.RapidsPluginImplicits._
import com.nvidia.spark.rapids.shims.{GpuWindowUtil, ShimExpression}
import scala.util.{Left, Right}

Expand Down Expand Up @@ -1709,8 +1710,9 @@ class RankFixer extends BatchedRunningWindowFixer with Logging {
}

override def close(): Unit = {
previousRank.foreach(_.close())
previousRank.foreach(_.safeClose())
previousRank = None
rowNumFixer.close()
}
}

Expand Down
Loading