Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc for PR status checks [skip ci] #3031

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Jul 27, 2021

fix #2855, following-up of #3028

@pxLi pxLi added the documentation Improvements or additions to documentation label Jul 27, 2021
Signed-off-by: Peixin Li <pxli@nyu.edu>
@pxLi pxLi changed the title add doc for PR status checks [skip ci] add doc for PR status checks Jul 27, 2021
@pxLi pxLi marked this pull request as draft July 27, 2021 09:17
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap lines to approx. 100 characters to match the style of the rest of the document. It makes viewing it from a terminal nicer and more consistent, and it also helps localize comments on PRs.

Also do we have plans to change the "Post processing -> Start post processing" section to something with a much better name? The fact that we have to document how to find logs after clicking the link is an indicator this could be much better.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@pxLi
Copy link
Collaborator Author

pxLi commented Jul 28, 2021

Please wrap lines to approx. 100 characters to match the style of the rest of the document. It makes viewing it from a terminal nicer and more consistent, and it also helps localize comments on PRs.

sure, will reformat the change.

Also do we have plans to change the "Post processing -> Start post processing" section to something with a much better name? The fact that we have to document how to find logs after clicking the link is an indicator this could be much better.

This is depends on blossom github support, we can file a feature request for them cc @zhanga5

@zhanga5
Copy link
Contributor

zhanga5 commented Jul 28, 2021

Also do we have plans to change the "Post processing -> Start post processing" section to something with a much better name? The fact that we have to document how to find logs after clicking the link is an indicator this could be much better.

This is depends on blossom github support, we can file a feature request for them cc @zhanga5

OK, I will follow up this

@pxLi pxLi marked this pull request as ready for review July 28, 2021 02:48
@pxLi pxLi changed the base branch from branch-21.10 to branch-21.08 July 28, 2021 02:48
@pxLi pxLi changed the base branch from branch-21.08 to branch-21.10 July 28, 2021 02:49
@pxLi pxLi changed the title add doc for PR status checks add doc for PR status checks [skip ci] Jul 28, 2021
@pxLi
Copy link
Collaborator Author

pxLi commented Jul 28, 2021

build

@pxLi pxLi merged commit 8c40497 into NVIDIA:branch-21.10 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants