Add a getting started guide on workload qualification [skip ci] #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a getting started guide on workload qualification
jlowe
reviewed
Nov 16, 2021
|
|
||
| This log can show you which operators(on what data type) can not run on GPU and what is the reason. | ||
| If it shows a specific Spark RAPIDS parameter which can be turned on to enable that feature, you can enable that parameter | ||
| and try the tool again. |
There was a problem hiding this comment.
Probably want to mention here that one shouldn't blindly enable parameters that are disabled by default without understanding the risks and applicability of that parameters ramifications to their specific application.
There was a problem hiding this comment.
I added some words to ask users to understand the risks of the parameters. How is now?
There was a problem hiding this comment.
This is better. Would be nice to link to the configs.md document here so users can know where to lookup any parameters they may find in the output.
There was a problem hiding this comment.
Added the configs doc link here.
tgravescs
reviewed
Nov 16, 2021
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Co-authored-by: Thomas Graves <tgraves@apache.org>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Add risks for parameter
Add disclaimer for parameters
Reword some statements
Add some words to explain the fallback.
Add configs doc
Reword some configs related words
Add a link in getting started md
tgravescs
reviewed
Nov 16, 2021
tgravescs
reviewed
Nov 16, 2021
tgravescs
reviewed
Nov 16, 2021
Add more words
tgravescs
changed the title
|
build |
|
@jlowe @tgravescs @sameerz should we merge this PR firstly if it is approved? |
sameerz
reviewed
Nov 18, 2021
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Fix some words
sameerz
reviewed
Nov 18, 2021
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Add an example for log messages
Add an example
sameerz
approved these changes
Nov 19, 2021
jlowe
approved these changes
Nov 19, 2021
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a getting started guide on workload qualification.