Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a getting started guide on workload qualification [skip ci] #4110
Add a getting started guide on workload qualification [skip ci] #4110
Changes from 1 commit
decce71
13a1c06
75bc077
e11c703
8de8e59
52dab29
94fd688
81d4403
22ef720
d9330a1
511576c
6277dc4
1369215
cee0fc0
43a576a
67c1dc6
fe2584d
cf27e7d
bbeb3a0
5a6cabd
ad6c178
abadf8b
44febae
5adbe6f
e7feb0e
a18b87a
fd3a743
b1b5d70
e96a768
a3f8a8c
2587531
487dd25
36c3036
5e65948
4ca269f
aedec7d
eabec6b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to mention here that one shouldn't blindly enable parameters that are disabled by default without understanding the risks and applicability of that parameters ramifications to their specific application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some words to ask users to understand the risks of the parameters. How is now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better. Would be nice to link to the configs.md document here so users can know where to lookup any parameters they may find in the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the configs doc link here.