Commonize v2 shim [databricks] #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <res_life@163.com>
res-life
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
|
build |
|
It would be better to give a short introduction of your change in the PR description. |
|
@firestarman @tgravescs Please help to review. |
tgravescs
reviewed
Nov 30, 2021
...plugin/src/main/301until310-nondb/scala/com/nvidia/spark/rapids/shims/v2/Spark30XShims.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Chong Gao <res_life@163.com>
|
build |
|
looks like there are compile errors on data bricks. 4 I think in total, here is one: 06:04:24 [ERROR] /home/ubuntu/spark-rapids/sql-plugin/src/main/301until330-all/scala/com/nvidia/spark/rapids/shims/v2/Spark30Xuntil33XShims.scala:323: type mismatch; |
tgravescs
reviewed
Dec 1, 2021
.../src/main/301until330-all/scala/com/nvidia/spark/rapids/shims/v2/Spark30Xuntil33XShims.scala
Outdated
Show resolved
Hide resolved
added 2 commits
December 2, 2021 10:49
This reverts commit 2554927.
Signed-off-by: Chong Gao <res_life@163.com>
|
build |
gerashegalov
reviewed
Dec 2, 2021
| @@ -441,12 +440,12 @@ | |||
| <source>${project.basedir}/src/main/301+-nondb/scala</source> | |||
| <source>${project.basedir}/src/main/301until320-all/scala</source> | |||
| <source>${project.basedir}/src/main/301until320-nondb/scala</source> | |||
| <source>${project.basedir}/src/main/301until330-all/scala</source> | |||
gerashegalov
reviewed
Dec 2, 2021
|
|
||
| override def getSparkShimVersion: ShimVersion = SparkShimServiceProvider.VERSION | ||
|
|
||
| override def hasCastFloatTimestampUpcast: Boolean = true |
There was a problem hiding this comment.
nit: why reorder methods?
Signed-off-by: Chong Gao <res_life@163.com>
|
build |
|
After reordering two methods, pre-merge failed, this should not impact the pre-merge. |
|
build |
jlowe
reviewed
Dec 2, 2021
Signed-off-by: Chong Gao <res_life@163.com>
|
build |
jlowe
approved these changes
Dec 3, 2021
tgravescs
approved these changes
Dec 3, 2021
res-life
pushed a commit
to res-life/spark-rapids
that referenced
this pull request
Dec 6, 2021
* Commonize v2 shim Signed-off-by: Chong Gao <res_life@163.com> * Reuse some codes Signed-off-by: Chong Gao <res_life@163.com> * Revert "Reuse some codes" This reverts commit 2554927. * Reuse codes Signed-off-by: Chong Gao <res_life@163.com> * Revert a file Signed-off-by: Chong Gao <res_life@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename SparkBaseShims to Spark30XShims, delete unused 312db sources directory in sql-plugin.
Fixes #3660
Signed-off-by: Chong Gao res_life@163.com