Implement getShuffleRDD and fixup mismatched output types on shuffle reuse [databricks] #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reuse Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
revans2
previously approved these changes
Dec 1, 2021
abellina
previously approved these changes
Dec 1, 2021
|
Databricks 9.1 build failed due to access restrictions on |
|
build |
gerashegalov
approved these changes
Dec 2, 2021
| import org.apache.spark.sql.execution.adaptive.{QueryStageExec, ShuffleQueryStageExec} | ||
|
|
||
| /** Utility methods for manipulating Catalyst classes involved in Adaptive Query Execution */ | ||
| object AQEUtils { |
There was a problem hiding this comment.
same as the db version? hopefully this will be combined after the commonizing PR #4235
There was a problem hiding this comment.
I don't think #4235 is going to address this. This change is only needed by spark312db, and there's no source directory for "everything except spark312db." I didn't bother to create one for this since the code is so small.
revans2
approved these changes
Dec 2, 2021
This was referenced Dec 2, 2021
andygrove
pushed a commit
to andygrove/spark-rapids
that referenced
this pull request
Dec 2, 2021
…reuse [databricks] (NVIDIA#4257) * Implement getShuffleRDD and fixup mismatched output types on shuffle reuse Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Fix Databricks 9.1 build
res-life
pushed a commit
to res-life/spark-rapids
that referenced
this pull request
Dec 6, 2021
…reuse [databricks] (NVIDIA#4257) * Implement getShuffleRDD and fixup mismatched output types on shuffle reuse Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Fix Databricks 9.1 build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4216.
This implements the getShuffleRDD interface for GpuShuffleExchangeExec and fixes an issue with ReusedExchangeExec caching CPU aggregation buffer types before they're updated with GPU aggregation buffer types. The plan is searched for instances where the ReusedShuffleExec output types do not match the underlying GPU shuffle output types, fixing the output types of ReusedShuffleExec to match the GPU shuffle.