-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config to limit maximum RMM pool size #517
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b047bb1
Add config to limit maximum RMM pool size
jlowe b8fbaeb
Address review comments
jlowe 68c8c57
Merge branch 'branch-0.2' into rmm-pool-size-limit
jlowe fa00136
Do not attempt to specify a limit when max alloc fraction is 1
jlowe fbc6962
Document artifical limit is not enforced when max alloc fraction == 1
jlowe 41d4f87
Merge branch 'branch-0.2' into rmm-pool-size-limit
jlowe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
tests/src/test/scala/com/nvidia/spark/rapids/GpuDeviceManagerSuite.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
* Copyright (c) 2020, NVIDIA CORPORATION. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.nvidia.spark.rapids | ||
|
||
import ai.rapids.cudf.{Cuda, DeviceMemoryBuffer} | ||
import org.scalatest.FunSuite | ||
|
||
import org.apache.spark.SparkConf | ||
import org.apache.spark.sql.SparkSession | ||
|
||
class GpuDeviceManagerSuite extends FunSuite with Arm { | ||
|
||
test("RMM pool limit") { | ||
SparkSession.getActiveSession.foreach(_.close()) | ||
GpuDeviceManager.shutdown() | ||
val totalGpuSize = Cuda.memGetInfo().total | ||
val initPoolFraction = 0.1 | ||
val maxPoolFraction = 0.2 | ||
val conf = new SparkConf() | ||
.set(RapidsConf.POOLED_MEM.key, "true") | ||
.set(RapidsConf.RMM_ALLOC_FRACTION.key, initPoolFraction.toString) | ||
.set(RapidsConf.RMM_ALLOC_MAX_FRACTION.key, maxPoolFraction.toString) | ||
try { | ||
TestUtils.withGpuSparkSession(conf) { _ => | ||
val initPoolSize = (totalGpuSize * initPoolFraction).toLong | ||
val allocSize = Math.max(initPoolSize - 1024 * 1024, 0) | ||
// initial allocation should fit within initial pool size | ||
withResource(DeviceMemoryBuffer.allocate(allocSize)) { _ => | ||
// this should grow the pool | ||
withResource(DeviceMemoryBuffer.allocate(allocSize)) { _ => | ||
assertThrows[OutOfMemoryError] { | ||
// this should exceed the specified pool limit | ||
DeviceMemoryBuffer.allocate(allocSize).close() | ||
} | ||
} | ||
} | ||
} | ||
} finally { | ||
GpuDeviceManager.shutdown() | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should document this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I should be more clear. In the case of UVM setting it above 1.0 might be logical so we should document in the config that this is happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think RMM's
pool_memory_resource
will still query the GPU and use it's reported total memory as a maximum limit internally, although I'm unsure what that API does when UVM is being used. I'll still add a comment saying the maximum limit is disabled if the specified fraction >= 1.