Add config to limit maximum RMM pool size #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
abellina
reviewed
Aug 6, 2020
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsConf.scala
Outdated
Show resolved
Hide resolved
abellina
reviewed
Aug 6, 2020
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsConf.scala
Outdated
Show resolved
Hide resolved
tgravescs
reviewed
Aug 6, 2020
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
abellina
previously approved these changes
Aug 6, 2020
tgravescs
previously approved these changes
Aug 6, 2020
|
build |
|
build |
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
revans2
reviewed
Aug 7, 2020
| } else { | ||
| // Do not attempt to enforce any artificial pool limit based on queried GPU memory size | ||
| // if config indicates all GPU memory should be used. | ||
| 0 |
There was a problem hiding this comment.
Sorry I should be more clear. In the case of UVM setting it above 1.0 might be logical so we should document in the config that this is happening.
There was a problem hiding this comment.
I think RMM's pool_memory_resource will still query the GPU and use it's reported total memory as a maximum limit internally, although I'm unsure what that API does when UVM is being used. I'll still add a comment saying the maximum limit is disabled if the specified fraction >= 1.
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
|
@revans2 this is ready for another look. |
revans2
approved these changes
Aug 10, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add config to limit maximum RMM pool size Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Address review comments Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Do not attempt to specify a limit when max alloc fraction is 1 Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Document artifical limit is not enforced when max alloc fraction == 1 Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add config to limit maximum RMM pool size Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Address review comments Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Do not attempt to specify a limit when max alloc fraction is 1 Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Document artifical limit is not enforced when max alloc fraction == 1 Signed-off-by: Jason Lowe <jlowe@nvidia.com>
pxLi
added a commit
to pxLi/spark-rapids
that referenced
this pull request
May 12, 2022
Signed-off-by: Peixin Li <pxli@nyu.edu>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Lowe jlowe@nvidia.com
Fixes #488.
This adds a new plugin config to artificially limit the amount of GPU memory that will be used by RMM in pool mode.
Note that this depends on rapidsai/cudf#5855 and must not be merged until that change is published in the cudf-0.15-SNAPSHOT artifact.