Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for split and getArrayIndex #527

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Aug 7, 2020

This is a first draft based off of rapidsai/cudf#5881 but since all of that is in flux this will need some changes too.

Some of the changes I made were really just band-aids, but we need to think about how we want to support converting between a Spark GpuColumnVector and a cudf ColumnVector, specifically the types and possibly the nullability.

This fixes #403
This fixes #70

@kuhushukla kuhushukla self-requested a review August 7, 2020 18:37
@kuhushukla
Copy link
Collaborator

Did a quick glance. Will look more into this in a bit.

@revans2 revans2 self-assigned this Aug 7, 2020
@revans2 revans2 added this to the Aug 3 - Aug 14 milestone Aug 7, 2020
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
kuhushukla
kuhushukla previously approved these changes Aug 7, 2020
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2
Copy link
Collaborator Author

revans2 commented Aug 10, 2020

Dependency was just merged into cudf. Need to wait for it to get through the build and be published. Then we can merge this in.

@revans2 revans2 changed the title [WIP] Add support for split and getArrayIndex Add support for split and getArrayIndex Aug 10, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Aug 10, 2020

build

@revans2 revans2 merged commit c4e66c6 into NVIDIA:branch-0.2 Aug 10, 2020
@sameerz sameerz added the feature request New feature or request label Aug 14, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Add in support for GetArrayItem [FEA] Support StringSplit
3 participants