Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in JVM extractListElement and stringSplitRecord [skip-ci] #5881

Merged
merged 35 commits into from
Aug 10, 2020

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Aug 7, 2020

This is based off of #5815, but I wanted to get it up ASAP so we could review it before the burn down completes. the only change to really look at is 8506d0a which has all of my changes in it.

@revans2 revans2 requested a review from a team as a code owner August 7, 2020 15:39
@revans2 revans2 self-assigned this Aug 7, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@jlowe jlowe added Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS labels Aug 7, 2020
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnVector.java Outdated Show resolved Hide resolved
java/src/main/native/src/ColumnVectorJni.cpp Show resolved Hide resolved
java/src/main/native/src/ColumnVectorJni.cpp Show resolved Hide resolved
Copy link
Contributor

@kuhushukla kuhushukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont have additional comments to Jason's. lgtm.

@revans2
Copy link
Contributor Author

revans2 commented Aug 7, 2020

@jlowe I think I have addressed all of your review comments.

@revans2 revans2 changed the title [WIP] Add in JVM extractListElement and stringSplitRecord [skip-ci] Add in JVM extractListElement and stringSplitRecord [skip-ci] Aug 10, 2020
@revans2 revans2 merged commit bdfa588 into rapidsai:branch-0.15 Aug 10, 2020
@revans2 revans2 deleted the java_array_ops branch August 10, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants