Issue 768 rtl #879
Closed
Issue 768 rtl #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding limited support for showing skosxl:prefLabels * Added SPARQL query to query for super properties of a property * Used graph-agnostic queries through default endpoint to retrieve label and superproperty of a property. * Fixed call to Namespace.shorten(). Added types to property declarations in test files. * Issue 666 - squash commits (#8) * Added preferredVocabUri parameter to Model::guessVocabularyFromURI() * Added preferredVocabUri parameter to Model::guessVocabularyFromURI() * Comment just to have one additionnal commit * Compared vocab on IDs rather than URIs * Add the preferred vocabulary parameter when calling guessVocabularyFromURI * Comments * 1. Ability to fetch and return dct:subject of ConceptSchemes in the list of Concept schemes. 2. Ability to fetch and return multiple concept schemes for which a concept is a top concept in the parent hierarchy (new 'tops' key in the JSON-LD result) * skos-xl labels should now work * fixing the preflabel right pad * fixing the unit tests * fixing the skosxl qtips not appearing after ajaxing content, related to NatLibFi#533 * removing unused ?member variable, fixes NatLibFi#655 * moving mapping concept notations inside the a element, related to NatLibFi#623 * Read property label from current vocabulary before querying the default graph * updating the composer dependencies before 1.10 release * Look for property label and superproperties in the current EasyRdf Model rather than making another SPARQL query. * Use locale-based sort to sort values in concept page * initializing the superprops variable as an empty array * pulled files from master * Issue NatLibFi#665 Remove SERVICE_LOGO old constant and related code * Add Jena Fuseki to gitignore * updating composer packages, related to NatLibFi#684 * running travis with php 7.0, related to NatLibFi#684 * migrating to phpunit 6, related to NatLibFi#684 * moving to new codeclimate reporter * removing copypaste error * updating the mockery package, related to NatLibFi#684 * moving old dependencies to composer, related to NatLibFi#684 * loading the remaining dependencies that were not managed by composer as a composer package, related to NatLibFi#684 * Fix hard crash on missng skosxl:literalForm If skosxl:literalForm is missing on a label resource the $label variable remains uninitialzed and causes a hard crash * finished jsonld augmentation * cleaned code and added phpdoc * Implements CBD solution for blank nodes and adds reification nodes * refactored duplicate code * adding a configurable property that enables defining a priority for label fallback languages, related to NatLibFi#688 * improving the fallback language order feature, related to NatLibFi#688 * fixing the missing prefLabel language tag when showing a fallback label, related to NatLibFi#688 * adding a few tests for getLanguageOrder(), related to NatLibFi#688 * using the configurable fallback languages for the concept property value labels as well, related to NatLibFi#688 * using the skosmos:feedbackLanguages for the rest api hierarchy fallback, related to NatLibFi#688 * fixing missing lang parameter from a getLanguageOrder-call, related to NatLibFi#688 * code style cleanup: removing trailing whitespaces * whoops * Cleaned for PR and made tests * add build/ directory to .gitignore * fixes NatLibFi#690 * using the configurable fallback language for the REST API children function as well * filtering out hiddenLabels always when the concept has been found earlier, related to NatLibFi#690 * fixes NatLibFi#692 * applying a band aid for the broken mobile screen vocabulary info layout, related to NatLibFi#691 * recoded long URIs as shortened versions as requested * only querying for concept info when the search has found some results, related to NatLibFi#696 * fix NatLibFi#701 updates embedded json-ld data correctly * add language ordering to passed through variables to javascript * fixing wrong translations * using a more specific selector for the sidebar custom scrollbar * fixing a bug with displaying language codes for fallback labels * using the configured languages as fallbacks too * fixing false language tags sometimes appearing with mapping concepts * Issue NatLibFi#661 add a copy to clipboard button * Add Dutch translations by @mrvdries and @ismakutl. Fixes NatLibFi#710 * css for the copy button * fixes hard crash when collection doesnt return a label * adding a random fallback for the guessLanguage so the negotiator wont crash when the accept header has not been set * run Travis tests with newer Fuseki 3.6.0 * define Code Climate variable as global, separating it from matrix vars * Remove support for obsolete APC caching functions. Fixes NatLibFi#728 * Issue NatLibFi#712: display the concepts of the first letter available * Default to the first letter of the alphabet when no letter is selected. Fixes NatLibFi#712 * Add Dockerfile and a docker-compose to run SKOSMOS with Fuseki * Add Dockerfile container_name's * Add volume binding example in comments for Fuseki * Rename Skosmos docker-compose created container name to skosmos * Fixes NatLibFi#638 * fix constructor call due to previously done refactoring(?) * Run Travis tests also under PHP 7.1 and 7.2 * add checks to prevent sizeof() related warnings in PHP 7.2 * fix PHP 7.1+ build test by changing the name for error raised * Changed test fuseki port to 13030; upgraded test fuseki to 3.7.0; fixed PHP 7.2+ build test * allow tests to fail on PHP 7.2 due to JsonLD compatibility problems * expect different exceptions depending on PHP version (7.0 vs 7.1+) * adjust build matrix: test fuseki SNAPSHOT only on php 7.1, allow failures on 7.2 & fuseki SNAPSHOT * further adjust build matrix * specify PHP versions without quotes * adjust build matrix: only test fuseki SNAPSHOT on php 7.1 * bump Fuseki version to 3.7.0 also on Travis tests * move notifications to new NatLibFi Slack instance * Allow request input to be mocked * Refactor getQueryParamArray to always return array * Add additional fields to JSON-LD context for search endpoint If additional fields are requested using the 'fields' parameter, add them to the JSON-LD context. Note: This will break any implementation that relies on the 'skos:' prefix being part of the keys. * Add mapping relations to JSON-LD context * Add unit test for NatLibFi#744 / PR NatLibFi#756. Fixes NatLibFi#744 * Open all hierarchies when a concept is in multiple schemes. Fixes NatLibFi#765 * fix layout issue due to having a <p> element instead of <span> in skosxl display * Change feedback message headers to use Reply-To and make name and e-mail optional. Fixes NatLibFi#761 * Set the feedback email sender address properly when a vocabulary-specific recipient has been set. Fixes NatLibFi#761 * Add Arabic translation from Transifex. Fixes NatLibFi#767 * Fix Dockerfile by automatically answering yes to apt-get install locales * Issue NatLibFi#738 replace .inc configuration files by .ttl (turtle) files. The cache that was created in the Model instance, now was moved to the GlobalConfig, but is still accessed from Model to add entries looked up. There is no more need of a separate .ttl file for vocabularies, as it is now part of the configuration file. Old files were removed. In order to maintain backward compatibility, most methods of GlobalConfig and of VocabularyConfig were maintained as-is. With internal changes to re-route requests to the right RDF objects. Tests were minor updates in tests, but only to replace .inc by .ttl or fix coverage annotations. * Fix scrutinizer issues * Remove unused graph variable from Model * Use a list for skosmos:languages * add skosmos:globalPlugins example which was forgotten in PR NatLibFi#769 * Use RDFS properties for language settings. Fixes NatLibFi#772 * Fix test config for NatLibFi#772 * Replace PHP explode function call by a Turtle list for globalPlugins * Include unit test for new globalPlugins with list, and update distributed configuration file * Issue NatLibFi#771 config migrate tool * Replace exit() by exceptions, and fail earlier if invalid mode * Leave values not defined as comments * Fix search with double quotes * Upgrade Travis config to use newest Fuseki 3.8.0 * Use Fuseki 3.8.0 by default for tests * fix getVersion when on a branch with no tags available in recent history * use the dev.finto.fi SPARQL endpoint as default endpoint, to match vocab config * Disable Travis tests for Fuseki snapshot. There is no longer a Fuseki1 distribution snapshot we could use, after building it was disabled in JENA-1573. * updated German translations. Credit: Jonas Waeber * updated French translations. Credit: Thomas Francart * updated Polish translations. Credit: Łukasz Szeremeta * update translation files to match latest template; no actual changes in translations * Add translations for Farsi, by Omid Ghiasvand and Reza Ghiasvand. Still missing true RTL support (NatLibFi#768) * fixes NatLibFi#714 * sorting concept property values with natural case sort when sortByNotation is true, fixes NatLibFi#737 * Fixed the variable name notsort for a clearer sort_by_notation * Avoid double encoding of search query string. Fixes NatLibFi#763 * fix issue regarding updating the json-ld data * Specify skosmos:defaultEndpoint as a resource, not literal. Fixes NatLibFi#786 * updated German translations for 100% coverage. Credit: Jonas Waeber * Fix PHP syntax when calling a method * Set a value for variable when declaring it * Avoid type coercion in JS when comparing values * Avoid declaring a variable twice * Remove unused variable * Remove duplicated semicolon * Add Vagrantfile and Ansible Playbook setup for deploying and running Skosmos in virtual environment * Add .vagrant and .DS_Store to .gitignore * Remove unnecessary installation of Python 2.7 and configure to use python3 * Removed old config files and added references to eclipse project file to .gitignore * Remove Fuseki deployment * Fix apt not installing php-mbstring by updating cache before apt install * Turn off verbose/debug mode for Ansible provisioner * Delete .DS_Store * Delete second .DS_Store * Remove unnecessary, duplicate configuration file * Add Vagrantfile and Ansible Playbook setup for deploying and running Skosmos in virtual environment * Add .vagrant and .DS_Store to .gitignore * Remove unnecessary installation of Python 2.7 and configure to use python3 * Removed old config files and added references to eclipse project file to .gitignore * Remove Fuseki deployment * Fix apt not installing php-mbstring by updating cache before apt install * Turn off verbose/debug mode for Ansible provisioner * Delete .DS_Store * Delete second .DS_Store * Remove unnecessary, duplicate configuration file * reorder .gitignore * Use correct value when retrieving settings * Add tests for GlobalConfig * Add more tests for VoacabularyConfig * Use array in the test for GlobalConfig::getGlobalPlugins * Fix parameter order for jena-text queries - MAX_N setting was being ignored. Fixes NatLibFi#794 * Loosen the check for port numbers in guessBaseHref. Fixes NatLibFi#796 * removed references to old configuration files * Choose feedback recipient based on selection on feedback form, not the URL from which the feedback page was invoked. Fixes NatLibFi#808 * Fix unit test that broke after the fix to NatLibFi#808 (cherry picked from commit 1a55e8b) * Fix fragile unit test (may break if /tmp/skosmos-template-cache exists but is owned by another user) * Fix config migration of LOG_FILE_NAME=null Fixes NatLibFi#801 * fixes NatLibFi#804 * fix some css; addresses issue NatLibFi#799 * #fixes NatLibFi#791; also update fuseki to 3.9.0 * Reenable Fuseki snapshot builds on Travis; use Fuseki2 3.9.0 on Travis instead of 3.8.0 * Don't allow Travis builds with PHP 7.2 to fail; run Fuseki snapshot builds with PHP 7.2. Related to NatLibFi#758 * check which locales are installed in Travis environment * Try to break unit tests by setting LANGUAGE=fr. Part of NatLibFi#816 * Always set LANGUAGE environment variable when setting LC_ALL. Fixes NatLibFi#816
Creation of specific css stylesheets for RTL mode.
… activate by default.
|
Thanks for the PR! Looking at the diff, it seems that this PR contains a lot of commits unrelated to the RTL support. Could you please rebase it on top of current (edited: changed LTR to RTL as it should be...) |
|
Hi Osma,
Thanks for your reply, yes we look that and that's the reason we created a
new "clean" branch to avoïd this problem, I will make a new pull request
when I finish to transfer all modification on this branch.
Just a little question, we made a draft pull request, to see if everything
was good (and that wasn't :)), but on your side, is this pull request
appear differently that a normal one ?
Thanks in advance,
Regards,
Le mer. 3 juil. 2019 à 16:52, Osma Suominen <notifications@github.com> a
écrit :
… Thanks for the PR!
Looking at the diff, it seems that this PR contains a lot of commits
unrelated to the LTR support. Could you please rebase it on top of current
master branch so that only the actual LTR changes are included?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#879?email_source=notifications&email_token=AJTFKWWFLH4PNQFFQ3WYVA3P5S4JLA5CNFSM4H5GTR32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZEWQNA#issuecomment-508127284>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJTFKWX7L7SZWKKWNFTSPXLP5S4JLANCNFSM4H5GTR3Q>
.
--
*Aurélien Barbier*
Designer d'expérience - DA UI/UX
06 38 83 22 09
www.experiencis.fr
|
You can do a new PR if you really want, but it's also possible to do a forced push to the branch
The problem is that the Files changed tab lists a huge number of changes and the great majority of them are unrelated changes done in recents months on the The fix is to rebase your branch on top of current upstream (NatLibFi/Skosmos) |
|
Superseded by #881, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #768
Contribution to support RTL mode in Skosmos.