Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Fix Sync after sites refactor #1

Closed
wants to merge 7 commits into from
Closed

[wip] Fix Sync after sites refactor #1

wants to merge 7 commits into from

Conversation

ayumi
Copy link

@ayumi ayumi commented Jul 25, 2017

Sites refactor was brave#9979

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

@NejcZdovc
Splits sites object in the app state
da5b46b 
Resolves #1856
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5699
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
@NejcZdovc
Fixes more bookmarks menu
87f144d
@NejcZdovc
Fixes no history bookmark
74d94ec
@NejcZdovc
Removes unnecessary site key lookups
77e393a
@NejcZdovc
Fixes existing tests
475c457
@NejcZdovc NejcZdovc force-pushed the refactor/#9978-sites branch 2 times, most recently from 475c457 to a77e9a8 Compare July 26, 2017 07:27
@NejcZdovc
Copy link
Owner

@ayumi PR was moved to the base project, you can find it here: brave#10136

@ayumi ayumi closed this Jul 26, 2017
@ayumi ayumi deleted the fix/sync-9978 branch July 26, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayumi @NejcZdovc