Upgrade eureka to be compatible with jakartaee #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces javax.{inject,annotation} with jakarta.{inject,annotation}.
Requires java 11 to build (jetty 11 in tests), but continues to target java 8.
Replaces google guice with guicedee guice that supports jakarta.inject.
Uses EurekaHttpClient as the interface used in DI
Removes unneeded JerseyReplicationClientTest.java
spencergibb
commented
Aug 19, 2022
| logger.info("Getting instance registry info from the eureka server : {} , delta : {}", this.remoteRegionURL, delta); | ||
|
|
||
| if (shouldUseExperimentalTransport()) { | ||
| // if (shouldUseExperimentalTransport()) { |
There was a problem hiding this comment.
Functionally, this is probably the biggest change I've made, relying on the EurekaHttpClient interface rather that trying to upgrade the usage of the internal jersey1 apache HTTP client.
There was a problem hiding this comment.
It seems like the internal discovery client takes care of cross region identity header, but EurekaHttpClient doesn't?
howardyuan
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade guice to com.guicedee.services:guice:1.2.2.1LifecycleInjectorFIXME 2.0todos are dealt with